<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-15"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Le 07/12/2011 23:49, Jack a écrit :
<blockquote cite="mid:4EDFED7F.7030302@rybn.org" type="cite">
<meta content="text/html; charset=ISO-8859-15"
http-equiv="Content-Type">
Le 07/12/2011 16:22, IOhannes m zmoelnig a écrit :
<blockquote cite="mid:4EDF84AE.8050807@iem.at" type="cite">
<pre wrap="">-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2011-12-07 15:36, Antoine Villeret wrote:
</pre>
<blockquote type="cite">
<pre wrap="">hi Iohannes,
i made a pull request directly on github
did you received it ? I think not... because I clone the sourceforge repos
and push it on a new github repo
it could have worked if I'd made a fork instead of a clone, isn't it ?
is there any way to do a fork from sourceforge repos ?
</pre>
</blockquote>
<pre wrap="">right, probably there is no way to do a proper pull request :-)
</pre>
<blockquote type="cite">
<pre wrap="">anyhow, I wrote some lines of code to add relative path support to pix_write
those are in the branch pix_write of my github repos :
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://github.com/avilleret/Gem">https://github.com/avilleret/Gem</a>
i don't know if this code is in the right Gem coding style but it was a
good opportunity for me to put my hands deep in the code...
</pre>
</blockquote>
<pre wrap="">ok, some comments:
- - you should not base your branches on top of each other but rather fork
them all from master (e.g. when merging in "pix_write", i don't want to
incidentally merge in "vertexarray")
- - try to avoid committing pd-patches and C++ code within the same
commit. conflicts in C++-code can usually easily be resolved, whereas
conflicts in Pd-patches are usually impossible to resolve (but for the
most trivial cases)
- - while the Gem code is full of bad examples, i try to gradually move
from C-type arrays/strings (e.g. "char*") to C++ STL-types (e.g.
"std::string")
- - members should be intialized via "member initialization" when possible.
e.g. use
</pre>
<blockquote type="cite">
<pre wrap="">foo::foo(void) : m_x(0), m_y(0) {}
</pre>
</blockquote>
<pre wrap="">rather than
</pre>
<blockquote type="cite">
<pre wrap="">foo::foo(void) { m_x=0; m_y=0; }
</pre>
</blockquote>
<pre wrap="">maybe it's time to wrap that up into a CodingStyle.txt file :-)
oh, and i would like to replace [pix_write] and [pix_writer] with
abstractions based on [pix_buffer] rather sooner than later.
</pre>
</blockquote>
<br>
I had the opportunity to work on this topic this evening.<br>
Here the abstraction.<br>
++<br>
<br>
Jack<br>
<br>
<br>
<blockquote cite="mid:4EDF84AE.8050807@iem.at" type="cite">
<pre wrap="">
fgmasdr
IOhannes
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://enigmail.mozdev.org/">http://enigmail.mozdev.org/</a>
iEYEARECAAYFAk7fhKsACgkQkX2Xpv6ydvQ1/ACgkwleMOvDnuSRWWhm2TpdBsB/
NlMAoJk57ECdplFAcbmBxWC8W1T9dJj/
=ew7K
-----END PGP SIGNATURE-----
</pre>
<pre wrap=""><fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
GEM-dev mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:GEM-dev@iem.at">GEM-dev@iem.at</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.puredata.info/listinfo/gem-dev">http://lists.puredata.info/listinfo/gem-dev</a>
</pre>
</blockquote>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
GEM-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:GEM-dev@iem.at">GEM-dev@iem.at</a>
<a class="moz-txt-link-freetext" href="http://lists.puredata.info/listinfo/gem-dev">http://lists.puredata.info/listinfo/gem-dev</a>
</pre>
</blockquote>
<br>
Some improvement in the help patch.<br>
++<br>
<br>
Jack<br>
<br>
<br>
</body>
</html>