<div dir="ltr">cool got it! give me a couple of days. thanks for the help!!! it is a new years resolution to figure all this git stuff out....<br><div class="gmail_extra"><br>>> these things are easy enough to fix (do a *mixed* reset of your branch to the split-point and factor new commits from there).<br>
<br></div><div class="gmail_extra">i will give it a shot!!<br><br>>> i could do that myself, but then the authorship of the patches would be lost and i'd rather leave that intact, so you get proper credits for your work.</div>
<div class="gmail_extra"><br>thanks! i want to learn anyway and there is no better way to learn than to do....<br><br></div><div class="gmail_extra">m<br><br><br></div><div class="gmail_extra"><div class="gmail_quote">On Tue, Jan 7, 2014 at 4:52 AM, IOhannes m zmölnig <span dir="ltr"><<a href="mailto:zmoelnig@iem.at" target="_blank">zmoelnig@iem.at</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="im">On 2014-01-07 00:07, me.grimm wrote:<br>
>>> cool. just do a pull request once you are ready<br>
><br>
> done! compiled fine after the changes....<br>
><br>
>>> (and nobody else was faster...)<br>
><br>
> ha! i guess not!!!<br>
<br>
</div>thanks for the quick fixes.<br>
however, some of the patches are not in a form that i can accept :-(<br>
<br>
+ ad5c6cd<br>
- adds a file "gemdefaultwindow.pd" which<br>
- has nothing to do with fixing the compilation problem<br>
- is generated during the build process (and will differ on various<br>
platforms) and is thus intentionally not included in the repository<br>
<br>
+ 31b8bc0<br>
- simply disables and thus breaks the functionality of the method it<br>
modifies<br>
<br>
a more cosmetic remark: i would prefer to have more descriptive titles<br>
of the commits. e.g. "remove default arguments from definitions" rather<br>
than "Fix on error: addition of default argument on redeclaration makes<br>
this".<br>
the problem is mainly, that the title of the commit (the first line in<br>
the commit message) should be terse and not contain more than 50 characters.<br>
<br>
<br>
these things are easy enough to fix (do a *mixed* reset of your branch<br>
to the split-point and factor new commits from there).<br>
i could do that myself, but then the authorship of the patches would be<br>
lost and i'd rather leave that intact, so you get proper credits for<br>
your work.<br>
<br>
<br>
fgadsr<br>
<span class=""><font color="#888888">IOhannes<br>
<br>
</font></span><br>_______________________________________________<br>
GEM-dev mailing list<br>
<a href="mailto:GEM-dev@iem.at">GEM-dev@iem.at</a><br>
<a href="http://lists.puredata.info/listinfo/gem-dev" target="_blank">http://lists.puredata.info/listinfo/gem-dev</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>____________________<br>m.e.grimm | m.f.a | ed.m.<br><a href="mailto:megrimm@gmail.com" target="_blank">megrimm@gmail.com</a><br>_________________________________
</div></div>