[PD-cvs] pd/src kernel.c,1.1.2.45,1.1.2.46
Mathieu Bouchard
matju at users.sourceforge.net
Thu Jun 28 09:57:18 CEST 2007
Update of /cvsroot/pure-data/pd/src
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv22442
Modified Files:
Tag: desiredata
kernel.c
Log Message:
removed some MAXPDSTRING
Index: kernel.c
===================================================================
RCS file: /cvsroot/pure-data/pd/src/Attic/kernel.c,v
retrieving revision 1.1.2.45
retrieving revision 1.1.2.46
diff -C2 -d -r1.1.2.45 -r1.1.2.46
*** kernel.c 28 Jun 2007 05:26:48 -0000 1.1.2.45
--- kernel.c 28 Jun 2007 07:57:16 -0000 1.1.2.46
***************
*** 1027,1033 ****
t_symbol *qualified_name(t_symbol *s) {
! char namespacename[MAXPDSTRING];
! sprintf(namespacename, "%s%s%s", pd_library_name, QUALIFIED_NAME, s->name);
! return gensym(namespacename);
}
--- 1027,1035 ----
t_symbol *qualified_name(t_symbol *s) {
! char *buf;
! asprintf(&buf, "%s%s%s", pd_library_name, QUALIFIED_NAME, s->name);
! t_symbol *sym = gensym(buf);
! free(buf);
! return sym;
}
***************
*** 1328,1331 ****
--- 1330,1334 ----
/* replace everything but [a-zA-Z0-9_] by "0x%x" */
+ /* BUG: buffer overflow */
static char *alternative_classname(char *classname) {
char *altname=(char*)malloc(sizeof(char)*MAXPDSTRING);
***************
*** 2164,2168 ****
static int binbuf_doopen(char *s, int mode) {
! char namebuf[MAXPDSTRING];
#ifdef MSW
mode |= O_BINARY;
--- 2167,2171 ----
static int binbuf_doopen(char *s, int mode) {
! char namebuf[strlen(s)+1];
#ifdef MSW
mode |= O_BINARY;
***************
*** 2173,2177 ****
static FILE *binbuf_dofopen(char *s, char *mode) {
! char namebuf[MAXPDSTRING];
sys_bashfilename(s, namebuf);
return fopen(namebuf, mode);
--- 2176,2180 ----
static FILE *binbuf_dofopen(char *s, char *mode) {
! char namebuf[strlen(s)+1];
sys_bashfilename(s, namebuf);
return fopen(namebuf, mode);
More information about the Pd-cvs
mailing list