[PD-dev] [ pure-data-Patches-1944415 ] plugin~ help crashes Pd-extended on Mac OS X
SourceForge.net
noreply at sourceforge.net
Sat Mar 21 16:06:37 CET 2009
Patches item #1944415, was opened at 2008-04-16 22:07
Message generated for change (Comment added) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1944415&group_id=55736
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: None
Status: Pending
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Hans-Christoph Steiner (eighthave)
Summary: plugin~ help crashes Pd-extended on Mac OS X
Initial Comment:
In the process of trying the help patch from #1944380, I just foudn another bug: the plugin~ help patch crashes Pd on Mac OS X 10.4.11/Intel using Pd-0.40.3-extended-20080403. I am guessing that this is related to the plugin files it is trying to load
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2009-03-21 15:06
Message:
i made a bugfixed version here:
http://bitbucket.org/moumar/ladspa/wiki/Home
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-03-21 03:13
Message:
bad news: it still crashes for me on Mac OS X 10.5.6/Intel and
Pd-0.41.4-extended-20090310 with a newly compiled plugin~.pd_darwin.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-03-21 03:05
Message:
checked into trunk:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=10883
----------------------------------------------------------------------
Comment By: zoom zoomzen (zoomzoomzen)
Date: 2009-01-05 17:38
Message:
hi,
here is a patch against Pd-0.40.3-extended that improves error checking
for plugin~ and prevent segfaults
diff -r b56f17673103 externals/plugin~/plugin~.c
--- a/externals/plugin~/plugin~.c Mon Jan 05 16:30:27 2009 +0100
+++ b/externals/plugin~/plugin~.c Mon Jan 05 16:59:40 2009 +0100
@@ -93,7 +93,7 @@ static void* plugin_tilde_new (t_symbol*
post("plugin~: Unable to open plugin");
}
}
-
+
/* Create in- and outlet(s) */
/* Allocate memory for in- and outlet pointers */
@@ -729,6 +729,11 @@ void plugin_tilde_ladspa_connect_audio (
unsigned port_index = 0;
unsigned input_count = 0;
unsigned output_count = 0;
+
+ if (x->plugin_library_filename == NULL) {
+ post("plugin~: plugin not found");
+ return;
+ }
/* Allocate out-of-place memory if needed */
if (plugin_tilde_ladspa_alloc_outofplace_memory (x, num_samples)) {
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2008-04-17 23:11
Message:
Logged In: NO
yeah, I submitted that help patch, and have discovered that the plugin~
object crashes when you give an argument that is a ladspa plugin that it
cannot find. the problem is a complete lack of error checking.
I will see if I can find the time/energy to put some simple error checking
in there, and submit it if I can
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1944415&group_id=55736
More information about the Pd-dev
mailing list