<br><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Even considering the actual implementation instead of the simplified<br>example, I wouldn't consider that renaming p1 to priority_min is
<br>really helping anyone, because they already know p1 is the minimum<br>priority by looking two lines above. All uses of p1 lie within 5 lines of<br>code, so using a longer name doesn't do much more than making the name
<br>longer to read. In some extreme situations (not this function) this can<br>make the code harder to read, as the longer names clutter the function.<br><br>> fprintf(stderr, "priority %d scheduling enabled.\n", priority);
<br>> fprintf(stderr, "couldn't change process priority to %d.\n",<br>> priority);<br>> fprintf(stderr, "%s (%d)", strerror(error_desc), error_desc);<br><br>You didn't replace the fprintfs by posts. It should be posts because then
<br>it can be routed through the GUI.</blockquote><div><br><br>True. <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> - Localization can be done here,
<br><br>No, localization should be done in the GUI. What should be done<br>server-side, is to make error messages easier to process by the GUI.</blockquote><div><br><br>Why not ? the engine, if running on a remote machine should also be able to send messages to the user in its language...
<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> - Safe fprintf can be used to avoid overflow.<br><br>Which overflow?</blockquote>
<div><br>see snprintf<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> An explicit name saves the dev brain power at coding time ;)
<br><br>I assert that often it doesn't. A name shouldn't be more explicit than it<br>needs to be, and it's certainly possible for names to be too explicit, and<br>i don't mean the "parental advisory" sys_defaultfontshit, I mean saying
<br>things that are too obvious because they're already in your face 15 times<br>in the same page and cause the code to go on for longer than you should<br>have to read.</blockquote><div><br>Quote from Wikipedia on software quality
<br>"Understandability
<p>Are variable names descriptive of the physical or functional
property represented? Do uniquely recognizable functions contain
adequate comments so that their purpose is clear? Are deviations from
forward logical flow adequately commented? Are all elements of an array
functionally related?"</p>+ <br>=> <a href="http://www.gnu.org/prep/standards/standards.html#Names">http://www.gnu.org/prep/standards/standards.html#Names</a><br>=> <a href="http://www.coding-guidelines.com/cbook/sent787.pdf">
http://www.coding-guidelines.com/cbook/sent787.pdf</a><br>=> <a href="http://www.raytheon.com.au/Files/Achieving%20Software%20Quality%20PDF.pdf#search=%22understandability%20readability%20quality%20C%22">http://www.raytheon.com.au/Files/Achieving%20Software%20Quality%20PDF.pdf#search=%22understandability%20readability%20quality%20C%22
</a><br>=> <a href="http://www.oreillynet.com/onlamp/blog/2004/03/the_worlds_two_worst_variable.html">http://www.oreillynet.com/onlamp/blog/2004/03/the_worlds_two_worst_variable.html</a><br>=> <a href="http://www.aivosto.com/project/help/pm-understandability.html">
http://www.aivosto.com/project/help/pm-understandability.html</a><br>=> <a href="http://en.wikipedia.org/wiki/Hrair_limit">http://en.wikipedia.org/wiki/Hrair_limit</a><br> <br></div></div>etc etc ...<br><br>my 2 cents about naming.
<br><br><br>++ <br><br>vincent<br>