<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">The last patch fixed some of the warnings. The rest I’m seeing from clang are simple stuff:<div class=""><br class=""></div><div class=""><div style="margin: 0px; line-height: normal;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>warning: using the result of an assignment as a condition without parentheses [-Wparentheses]</div><div style="margin: 0px; line-height: normal; min-height: 14px;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>aka</div><div style="margin: 0px; line-height: normal;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>assignments in for loops & if/while statements should be wrapped in parens</div><div style="margin: 0px; line-height: normal; min-height: 14px;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span></div><div style="margin: 0px; line-height: normal;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>warning: '&&' within '||' [-Wlogical-op-parentheses], so added paren wraps</div><div style="margin: 0px; line-height: normal; min-height: 14px;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span></div><div style="margin: 0px; line-height: normal;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>switch statement not handling all enumerations, so added default: break;</div><div class=""><br class="webkit-block-placeholder"></div><div class="">Note: this is only for sources used by libpd.</div><div class=""><br class=""></div><div class="">Here’s a patch:</div><div class=""><br class=""></div><div class=""></div></div></body></html>