<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""><div class=""><br class=""><div class="">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">--------<br class="">Dan Wilcox<br class=""><a href="https://twitter.com/danomatika" class="">@danomatika</a><br class=""><a href="http://danomatika.com" class="">danomatika.com</a><br class=""><div class=""><a href="http://robotcowboy.com" class="">robotcowboy.com</a></div></div>
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On Mar 24, 2016, at 9:27 PM, Dan Wilcox <<a href="mailto:danomatika@gmail.com" class="">danomatika@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">The last patch fixed some of the warnings. The rest I’m seeing from clang are simple stuff:<div class=""><br class=""></div><div class=""><div style="margin: 0px; line-height: normal;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>warning: using the result of an assignment as a condition without parentheses [-Wparentheses]</div><div style="margin: 0px; line-height: normal; min-height: 14px;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>aka</div><div style="margin: 0px; line-height: normal;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>assignments in for loops & if/while statements should be wrapped in parens</div><div style="margin: 0px; line-height: normal; min-height: 14px;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span></div><div style="margin: 0px; line-height: normal;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>warning: '&&' within '||' [-Wlogical-op-parentheses], so added paren wraps</div><div style="margin: 0px; line-height: normal; min-height: 14px;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span></div><div style="margin: 0px; line-height: normal;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>switch statement not handling all enumerations, so added default: break;</div><div class=""><br class="webkit-block-placeholder"></div><div class="">Note: this is only for sources used by libpd.</div><div class=""><br class=""></div><div class="">Here’s a patch:</div><div class=""><br class=""></div><div class=""></div></div></div><span id="cid:AA03A926-A2FE-4DAB-AC12-E78B01CB9DD9@hsd1.co.comcast.net."><warning_fixes.patch></span><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class=""></div><div class="">
<div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""></div></div><div class=""><blockquote type="cite" class=""><div class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">On Mar 22, 2016, at 10:39 AM, Miller Puckette <<a href="mailto:msp@ucsd.edu" class="">msp@ucsd.edu</a>> wrote:<br class=""><br class="">It's already in and up - check away :)<br class=""><br class="">M<br class="">On Tue, Mar 22, 2016 at 10:37:20AM -0600, Dan Wilcox wrote:<br class=""><blockquote type="cite" class="">Sweet. clang on OSX gives me about 100+ warnings when building the pure-data sources for libpd, most of which involve simple things like suggested paren wraps, “implicit conversion loses integer precision,” etc. These might be related to what iOhannes is seeing. I’ll wait to see if this bugfix work is accepted and then I can make a similar patch for the warnings.<br class=""><br class="">--------<br class="">Dan Wilcox<br class="">@danomatika <<a href="https://twitter.com/danomatika" class="">https://twitter.com/danomatika</a>><br class=""><a href="http://danomatika.com/" class="">danomatika.com</a><span class="Apple-converted-space"> </span><<a href="http://danomatika.com/" class="">http://danomatika.com/</a>><br class=""><a href="http://robotcowboy.com/" class="">robotcowboy.com</a><span class="Apple-converted-space"> </span><<a href="http://robotcowboy.com/" class="">http://robotcowboy.com/</a>><br class=""><blockquote type="cite" class="">On Mar 22, 2016, at 5:00 AM,<span class="Apple-converted-space"> </span><a href="mailto:pd-dev-request@lists.iem.at" class="">pd-dev-request@lists.iem.at</a><span class="Apple-converted-space"> </span>wrote:<br class=""><br class="">From: IOhannes m zmölnig <<a href="mailto:zmoelnig@iem.at" class="">zmoelnig@iem.at</a><span class="Apple-converted-space"> </span><<a href="mailto:zmoelnig@iem.at" class="">mailto:zmoelnig@iem.at</a>>><br class="">Subject: Re: [PD-dev] Memory leaks?<br class="">Date: March 21, 2016 at 3:29:25 PM MDT<br class="">To:<span class="Apple-converted-space"> </span><a href="mailto:pd-dev@lists.iem.at" class="">pd-dev@lists.iem.at</a><span class="Apple-converted-space"> </span><<a href="mailto:pd-dev@lists.iem.at" class="">mailto:pd-dev@lists.iem.at</a>><br class=""><br class=""><br class="">On 03/21/2016 09:51 PM, Miller Puckette wrote:<br class=""><blockquote type="cite" class="">Yep, thanks. Fixing it now...<br class=""></blockquote><br class="">since you seem to be in bug-squashing mode: there are about 100 more<br class="">bugs waiting to be fixed :-)</blockquote></blockquote></blockquote></div></blockquote></div><br class=""><div class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">--------<br class="">Dan Wilcox<br class=""><a href="https://twitter.com/danomatika" class="">@danomatika</a><br class=""><a href="http://danomatika.com/" class="">danomatika.com</a><br class=""><div class=""><a href="http://robotcowboy.com/" class="">robotcowboy.com</a></div><div class=""><br class=""></div></div></div></div></div></div></div></blockquote></div><br class=""></div></div></body></html>