<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Yes, you can. I only closed it since I thought it involved too many small changes, but I can reopen. The warning-fixes3 patch is basically the same fixes just without adding the parentheses around assignments.<div class=""><br class=""></div><div class=""><br class=""><div class="">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">--------<br class="">Dan Wilcox<br class=""><a href="https://twitter.com/danomatika" class="">@danomatika</a><br class=""><a href="http://danomatika.com" class="">danomatika.com</a><br class=""><div class=""><a href="http://robotcowboy.com" class="">robotcowboy.com</a></div></div>
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On Apr 2, 2016, at 10:43 PM, Miller Puckette <<a href="mailto:msp@ucsd.edu" class="">msp@ucsd.edu</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">I notice that the "warning-fixes" pull request is marked 'closed' - is it<br class="">still what I should be looking at?<br class=""><br class="">thanks<br class="">M<br class=""><br class="">On Fri, Apr 01, 2016 at 02:47:19AM -0600, Dan Wilcox wrote:<br class=""><blockquote type="cite" class="">Also, let me know if I should submit patches like this to the patch tracker. I figured I’d ask for feedback and take a couple stabs at it first here & on GitHub before adding any more noise to SF.<br class=""><br class="">--------<br class="">Dan Wilcox<br class="">@danomatika <<a href="https://twitter.com/danomatika" class="">https://twitter.com/danomatika</a>><br class=""><a href="http://danomatika.com" class="">danomatika.com</a> <<a href="http://danomatika.com/" class="">http://danomatika.com/</a>><br class=""><a href="http://robotcowboy.com" class="">robotcowboy.com</a> <<a href="http://robotcowboy.com/" class="">http://robotcowboy.com/</a>><br class=""><blockquote type="cite" class="">On Apr 1, 2016, at 2:36 AM, Dan Wilcox <<a href="mailto:danomatika@gmail.com" class="">danomatika@gmail.com</a>> wrote:<br class=""><br class="">Since no one is biting, I managed to fix most of the warnings by defining HAVE_ALLOCA_H and -Wno-parentheses in the Makefile.<br class=""><br class="">Here’s a patch with the residuals: <br class=""><br class="">* add default: break; for unhandled case statements<br class="">* change stddef.h include to stdlib.h for alloca() on BSD as per Tobias request<br class=""><br class=""><warning_fixes3.patch><br class=""><br class=""><blockquote type="cite" class="">Howdy all,<br class=""><br class="">I put the proposed changes in the previous patches into a couple WIP branches on GH.<br class=""><br class=""><a href="https://github.com/pure-data/pure-data/pull/11" class="">https://github.com/pure-data/pure-data/pull/11</a> <<a href="https://github.com/pure-data/pure-data/pull/11" class="">https://github.com/pure-data/pure-data/pull/11</a>> <<a href="https://github.com/pure-data/pure-data/pull/11" class="">https://github.com/pure-data/pure-data/pull/11</a> <<a href="https://github.com/pure-data/pure-data/pull/11" class="">https://github.com/pure-data/pure-data/pull/11</a>>><br class=""><br class=""><a href="https://github.com/pure-data/pure-data/pull/12" class="">https://github.com/pure-data/pure-data/pull/12</a> <<a href="https://github.com/pure-data/pure-data/pull/12" class="">https://github.com/pure-data/pure-data/pull/12</a>> <<a href="https://github.com/pure-data/pure-data/pull/12" class="">https://github.com/pure-data/pure-data/pull/12</a> <<a href="https://github.com/pure-data/pure-data/pull/12" class="">https://github.com/pure-data/pure-data/pull/12</a>>><br class=""></blockquote><br class="">--------<br class="">Dan Wilcox<br class="">@danomatika <<a href="https://twitter.com/danomatika" class="">https://twitter.com/danomatika</a>><br class=""><a href="http://danomatika.com" class="">danomatika.com</a> <<a href="http://danomatika.com/" class="">http://danomatika.com/</a>><br class=""><a href="http://robotcowboy.com" class="">robotcowboy.com</a> <<a href="http://robotcowboy.com/" class="">http://robotcowboy.com/</a>><br class=""></blockquote><br class=""></blockquote></div></div></blockquote></div><br class=""></div></body></html>