<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Yeah, I think the complaint is mainly about possible loss of precision so (I may be wrong), the float to int cast might be fine.<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 2, 2017, at 11:57 PM, Miller Puckette <<a href="mailto:msp@ucsd.edu" class="">msp@ucsd.edu</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Or (aha) - I could make up new function names for the "int" versions and<br class="">change the pd sources to use them, and declare the existing ones obsolete...?<br class=""><br class="">In fact, is there any reason one can't just globally replace every call<br class="">to atom_getint and atom_getintarg with the atom_getfloat equivalent - let<br class="">externs blithely call atom_getint and get a t_int back all they want.<br class=""><br class="">That would touch a lot of files so if I do it perhaps I should make sure<br class="">to do all the PR-merging I possibly can beforehand.<br class=""><br class="">AND: there's no reason I can't assign a float to an int without a cast, is<br class="">there? As I understand it the only clang complaint is int-to-smaller-int<br class="">conversions. So int x = atom_getfloat(&atom) is still kosher, correct?<br class=""><br class="">thanks<br class="">Miller<br class="">On Sat, Dec 02, 2017 at 02:50:57PM -0800, Miller Puckette wrote:<br class=""><blockquote type="cite" class="">I think the use of "t_int" in m_pd.h is incorrect - it should have been<br class="">int. But it's a mistake I think is now ironed in and we're stuck with it.<br class=""><br class=""><br class="">M<br class=""><br class="">On Sat, Dec 02, 2017 at 10:25:07PM +0100, Dan Wilcox wrote:<br class=""><blockquote type="cite" class="">I was following IOhannes' prompt about t_int: "rule of thumb: never use it for anything but passing data to perform-routines."<br class=""><br class=""><blockquote type="cite" class="">On Dec 2, 2017, at 10:22 PM, Miller Puckette <<a href="mailto:msp@ucsd.edu" class="">msp@ucsd.edu</a>> wrote:<br class=""><br class="">I'm pretty confused about this. I believe it was "t_int" in 0.48-0, and<br class="">I see that your PR changesit from "t_int" to "int" - and I believe<br class="">it has to be "t_int" for back compatibility...<br class=""><br class="">cheers<br class="">M<br class=""><br class="">On Sat, Dec 02, 2017 at 10:16:44PM +0100, Dan Wilcox wrote:<br class=""><blockquote type="cite" class="">I think I had already fixed this: <a href="https://github.com/pure-data/pure-data/pull/223" class="">https://github.com/pure-data/pure-data/pull/223</a> <<a href="https://github.com/pure-data/pure-data/pull/223" class="">https://github.com/pure-data/pure-data/pull/223</a>> (?) Or am I missing something?<br class=""><br class=""><blockquote type="cite" class="">On Dec 2, 2017, at 8:40 PM, Miller Puckette <<a href="mailto:msp@ucsd.edu" class="">msp@ucsd.edu</a>> wrote:<br class=""><br class="">I had one small ouch: I don't think I can compatibly change t_int to int<br class="">in m_pd.h (this is mentioned on another thread somewhere). I don't know how<br class="">to make clang pipe down about this short of casting almost every call to<br class="">atom_getint*() in the whole tree. Yuck... Maybe it's better just to tell<br class="">clang to be more permissive (if that's possible)?<br class=""></blockquote><br class="">--------<br class="">Dan Wilcox<br class="">@danomatika <<a href="http://twitter.com/danomatika" class="">http://twitter.com/danomatika</a>><br class=""><a href="http://danomatika.com" class="">danomatika.com</a> <<a href="http://danomatika.com/" class="">http://danomatika.com/</a>><br class=""><a href="http://robotcowboy.com" class="">robotcowboy.com</a> <<a href="http://robotcowboy.com/" class="">http://robotcowboy.com/</a>><br class=""><br class=""><br class=""><br class=""></blockquote></blockquote><br class="">--------<br class="">Dan Wilcox<br class="">@danomatika <<a href="http://twitter.com/danomatika" class="">http://twitter.com/danomatika</a>><br class=""><a href="http://danomatika.com" class="">danomatika.com</a> <<a href="http://danomatika.com/" class="">http://danomatika.com/</a>><br class=""><a href="http://robotcowboy.com" class="">robotcowboy.com</a> <<a href="http://robotcowboy.com/" class="">http://robotcowboy.com/</a>><br class=""><br class=""><br class=""><br class=""></blockquote><br class=""><blockquote type="cite" class="">_______________________________________________<br class="">Pd-dev mailing list<br class=""><a href="mailto:Pd-dev@lists.iem.at" class="">Pd-dev@lists.iem.at</a><br class="">https://lists.puredata.info/listinfo/pd-dev<br class=""></blockquote><br class=""><br class="">_______________________________________________<br class="">Pd-dev mailing list<br class=""><a href="mailto:Pd-dev@lists.iem.at" class="">Pd-dev@lists.iem.at</a><br class="">https://lists.puredata.info/listinfo/pd-dev<br class=""></blockquote></div></div></blockquote></div><br class=""><div class="">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">--------</div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">Dan Wilcox</div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><a href="http://twitter.com/danomatika" class="">@danomatika</a></div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><a href="http://danomatika.com" class="">danomatika.com</a></div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><a href="http://robotcowboy.com" class="">robotcowboy.com</a></div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br class=""></div><br class="Apple-interchange-newline">
</div>
<br class=""></div></body></html>