[PD] pd and tcp: what to do against crashes?

[Martin Peach]

Roman Haefeli wrote:
> On Sun, 2009-02-22 at 17:30 -0500, Martin Peach wrote:
> 
>> Maybe you could try it (I just uploaded it to the svn at 
>> http://pure-data.svn.sourceforge.net/viewvc/pure-data/trunk/externals/mrpeach/net/) 
>> and see if anything changes.
>>
> now, i cannot compile it anymore, when i do:
> 
> cd <pd-svn>/externals/
> make mrpeach
> 
> i get:
> 
> cc -DPD -O2 -I/home/roman/pd-svn/pd/src -Wall -W -ggdb -I/home/roman/pd-svn/Gem/src -I/home/roman/pd-svn/externals/pdp/include -DUNIX -Dunix -fPIC -o "/home/roman/pd-svn/externals/mrpeach/net/tcpserver.o" -c "/home/roman/pd-svn/externals/mrpeach/net/tcpserver.c"
> /home/roman/pd-svn/externals/mrpeach/net/tcpserver.c: In function 'tcpserver_send_buf':
> /home/roman/pd-svn/externals/mrpeach/net/tcpserver.c:387: error: 'errno' undeclared (first use in this function)
> /home/roman/pd-svn/externals/mrpeach/net/tcpserver.c:387: error: (Each undeclared identifier is reported only once
> /home/roman/pd-svn/externals/mrpeach/net/tcpserver.c:387: error: for each function it appears in.)


You need to add
#include <errno.h>
for linux it seems.
I have added that and committed it.

> /home/roman/pd-svn/externals/mrpeach/net/tcpserver.c:375: warning: unused variable 'timebefore'
> /home/roman/pd-svn/externals/mrpeach/net/tcpserver.c: In function 'tcpserver_send':
> /home/roman/pd-svn/externals/mrpeach/net/tcpserver.c:414: warning: unused parameter 's'
> /home/roman/pd-svn/externals/mrpeach/net/tcpserver.c: In function 'tcpserver_client_send':
> /home/roman/pd-svn/externals/mrpeach/net/tcpserver.c:517: warning: unused parameter 's'
> /home/roman/pd-svn/externals/mrpeach/net/tcpserver.c: In function 'tcpserver_broadcast':
> /home/roman/pd-svn/externals/mrpeach/net/tcpserver.c:549: warning: unused parameter 's'
> /home/roman/pd-svn/externals/mrpeach/net/tcpserver.c: In function 'tcpserver_connectpoll':
> /home/roman/pd-svn/externals/mrpeach/net/tcpserver.c:595: warning: pointer targets in passing argument 3 of 'accept' differ in signedness

These are just warnings.

Martin