<html><body><div style="color:#000; background-color:#fff; font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px"><div style="" class="" id="yiv5267735897"><div style="" class=""><div class="" style="color:#000;background-color:#fff;font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px;"><div style="" class="" id="yiv5267735897"><div style="" class="" id="yiv5267735897yui_3_16_0_1_1412911519194_14225"><div class="" id="yiv5267735897yui_3_16_0_1_1412911519194_14224" style="color:#000;background-color:#fff;font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px;"><div style="" class=""><span style="" class="" id="yiv5267735897yui_3_16_0_6_1412911519194_13">Hi Chris,<br style="" clear="none"> That's all great advice in general. But then there's this thread in particular, where at least
two perfectly capable developers chose to advocate for a trivial feature to be added to Pd rather than taking 10 minutes to implement it and make a "</span>small, clean, self contained patch" as you suggest. Why do you think that is?<br><br>In the meantime I'll continue doing exactly the healthy development process you describe, in Pd-l2ork.<br><br>-Jonathan<br style="" class=""><br style="" class=""></div><div style="" class="" id="yiv5267735897yqt02746"><div style="" class="" id="yiv5267735897yqt29936"><div class="" id="yiv5267735897yui_3_16_0_6_1412911519194_7" style="display: block;"> <div class="" style="font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px;"> <div class="" style="font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px;"> <div style="" class="" dir="ltr"> <font style="" class="" face="Arial" size="2"> On Thursday, October 9, 2014
11:18 PM, Chris McCormick <chris@mccormick.cx> wrote:<br style="" class="" clear="none"> </font> </div> <br style="" class="" clear="none"><br style="" class="" clear="none"> <div style="" class="">On 09/10/14 22:51, Ivica Ico Bukvic wrote:<br style="" class="" clear="none">> <sigh>... One could argue that
those using a pd-fork would benefit, and<br style="" class="" clear="none">> just maybe if vanilla contributors felt compelled to do so, they could<br style="" class="" clear="none">> also borrow code and implement it in their version as well?<br style="" class="" clear="none"><br style="" class="" clear="none">I'm confused, is this a pull request?<br style="" class="" clear="none"><br style="" class="" clear="none">In my experience the most effective way to get code merged into an open<br style="" class="" clear="none">source project is as follows:<br style="" class="" clear="none"><br style="" class="" clear="none"> * Make a small, clean, self contained patch that changes as little of<br style="" class="" clear="none">the codebase as possible to accomplish a goal.<br style="" class="" clear="none"><br style="" class="" clear="none"> * Format your code to match the style of the codebase it is going in to.<br style="" class="" clear="none"><br
style="" class="" clear="none"> * Advocate for the patch directly with the maintainer and on the<br style="" class="" clear="none">mailing list. In the past "lots of people have requested this feature"<br style="" class="" clear="none">has worked for me as a lobbying point.<br style="" class="" clear="none"><br style="" class="" clear="none"> * If changes are suggested by the maintainer, address them and resubmit.<br style="" class="" clear="none"><br style="" class="" clear="none"> * Accept that some patches simply won't go in. In that case you are of<br style="" class="" clear="none">course welcome to fork, or to maintain the patch in a parallel branch.<br style="" class="" clear="none"><br style="" class="" clear="none"> * Don't be a dick. I'm happy to note that the era of Pd-powered<br style="" class="" clear="none">missiles seems to be over. Good riddance!<br style="" class="" clear="none"><br style="" class="" clear="none">Here is someone smarter
than me writing in more depth on this subject:<br style="" class="" clear="none"><br style="" class="" clear="none"><a style="" class="" rel="nofollow" shape="rect" target="_blank" href="http://people.redhat.com/rjones/how-to-supply-code-to-open-source-projects/#patches">http://people.redhat.com/rjones/how-to-supply-code-to-open-source-projects/#patches</a><br style="" class="" clear="none"><br style="" class="" clear="none">Of course, Pd-l2ork is a fork and you are obviously welcome to do<br style="" class="" clear="none">whatever you want. What I don't think
is
constructive is implying that<br style="" class="" clear="none">Miller should be traipsing through the Pd-l2ork codebase and cherry<br style="" class="" clear="none">picking stuff he likes out and doing the work to merge those changes<br style="" class="" clear="none">cleanly into Pd. Just think about how you'd react if someone forked<br style="" class="" clear="none">Pd-l2ork, made monolithic changes to the codebase, and then asked you to<br style="" class="" clear="none">go through it and find stuff you might like to merge back into Pd-l2ork.<br style="" class="" clear="none"><br style="" class="" clear="none">Traditionally in open source projects that isn't the way that software<br style="" class="" clear="none">gets patched. Traditionally, a community of developers tries to submit<br style="" class="" clear="none">patches to a maintainer and lobbies for their acceptance. We are all<br style="" class="" clear="none">very busy and that seems to be the
most effective way to get code merged.<br style="" class="" clear="none"><br style="" class="" clear="none">Let me re-iterate again that you have every right not to do this, and<br style="" class="" clear="none">your fork is an
amazing piece of work, and I wish you good luck and much<br style="" class="" clear="none">genuine respect for what you guys have created. *If* you or anybody else<br style="" class="" clear="none">wants patches to go into Miller's Pd though, then they need to do the<br style="" class="" clear="none">proper work of trying to get them in there. Our community seems to not<br style="" class="" clear="none">be great at this process and I don't know why that is. I do think it's<br style="" class="" clear="none">something we can fix on an individual level however.<br style="" class="" clear="none"><br style="" class="" clear="none">Let me now attempt to demonstrate with [list foreach]. [1]<br style="" class="" clear="none"><br style="" class="" clear="none">Tooooooooltiiiiiiiips,<br style="" class="" clear="none"><br style="" class="" clear="none">Chris.<br style="" class="" clear="none"><br style="" class="" clear="none">[1] <a style="" class=""
rel="nofollow" shape="rect" target="_blank" href="http://www.youtube.com/watch?v=2Y_Jp6PxsSQ#t=19">http://www.youtube.com/watch?v=2Y_Jp6PxsSQ#t=19</a><br style="" class="" clear="none"><br style="" class="" clear="none">-- <br style="" class="" clear="none"><a style="" class="" rel="nofollow" shape="rect" target="_blank" href="http://mccormick.cx/">http://mccormick.cx/</a><div style="" class="" id="yiv5267735897yqtfd26836"><br style="" class="" clear="none"><br style="" class="" clear="none">_______________________________________________<br style="" class="" clear="none"><a style="" class="" rel="nofollow" shape="rect" ymailto="mailto:Pd-list@lists.iem.at" target="_blank" href="mailto:Pd-list@lists.iem.at">Pd-list@lists.iem.at</a> mailing list<br style="" class="" clear="none">UNSUBSCRIBE and account-management -> <a style="" class="" rel="nofollow" shape="rect" target="_blank"
href="http://lists.puredata.info/listinfo/pd-list">http://lists.puredata.info/listinfo/pd-list</a><br style="" class="" clear="none"></div><br style="" class="" clear="none"><br style="" class="" clear="none"></div> </div> </div> </div></div></div> </div></div></div></div></div></div></div></body></html>