<div dir="ltr"><div class="gmail_default" style=""><font face="verdana, sans-serif">I grepped through a bunch of externals. Here's a list of what might be affected, arranged by the _glist struct members:</font><br><br><br><div class="gmail_default" style=""><font face="verdana, sans-serif">gl_next:</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">iem/iemguts/src/findbrokenobjects.c:132: for (c = pd_getcanvaslist(); c; c = c->gl_next) {</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">moonlib/absolutepath.c:73: if((!retcan)&&(can->gl_next)) retcan=getcanvas((t_glist *)can->gl_next,d0);</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">moonlib/relativepath.c:73: if((!retcan)&&(can->gl_next)) retcan=getcanvas((t_glist *)can->gl_next,d0);</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif"><br></font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">gl_env:</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">moonlib/absolutepath.c:60: if((can->gl_env)&&(can->gl_env->ce_dollarzero==d0))</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">moonlib/absolutepath.c:94: //post("found $0 canvas : %x %d ",x->x_canvas, x->x_canvas->gl_env->ce_dollarzero );</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">moonlib/relativepath.c:60: if((can->gl_env)&&(can->gl_env->ce_dollarzero==d0))</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">moonlib/relativepath.c:92: //post("found $0 canvas : %x %d ",x->x_canvas, x->x_canvas->gl_env->ce_dollarzero );</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">pdp/opengl/system/pdp_3Dcontext_glx.c:43:typedef struct _gl_env</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">pdp/opengl/system/pdp_3Dcontext_glx.c:56:} t_gl_env;</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">pdp/opengl/system/pdp_3Dcontext_glx.c:58:static t_gl_env pdp_glx_env;</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">tof/src/tof.h:44:<span class="" style="white-space:pre"> </span> return (canvas->gl_env != 0);</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif"><br></font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">gl_havewindow:</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">grill/trunk/flext/source/flattr_ed.cpp:795: if(!gl->gl_isgraph || gl->gl_havewindow) {</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">grill/trunk/flext/source/flattr_ed.cpp:828: if(!gl->gl_isgraph || gl->gl_havewindow) {</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/cyclone/hammer/comment.c:343: if (!glist->gl_havewindow)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/cyclone/hammer/comment.c:491:<span class="" style="white-space:pre"> </span>if (glist->gl_havewindow)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/pddp/pddplink.c:95: if (glist_isvisible(glist) && glist->gl_havewindow)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/pddp/pddplink.c:120: if ((glist->gl_havewindow || x->x_isgopvisible)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/pddp/pddplink.c:130: if ((glist->gl_havewindow || x->x_isgopvisible)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/pddp/pddplink.c:192: if (glist->gl_havewindow || x->x_isgopvisible)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/toxy/pluswidget.c:142: if (glist_isvisible(glist) && glist->gl_havewindow)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/toxy/pluswidget.c:172: if (glist->gl_havewindow)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/toxy/pluswidget.c:183: if (glist->gl_havewindow)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/toxy/pluswidget.c:195: if (glist->gl_havewindow)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/toxy/widget.c:966: if (x->x_glist->gl_havewindow) /* LATER calculate on-parent coords */</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/toxy/widget.c:985: if (x->x_glist->gl_havewindow) /* LATER calculate on-parent coords */</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">pddp/helplink.c:99: if (glist_isvisible(glist) && glist->gl_havewindow)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">pddp/helplink.c:132: if ((glist->gl_havewindow || x->x_isgopvisible)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">pddp/helplink.c:151: if ((glist->gl_havewindow || x->x_isgopvisible)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">pddp/helplink.c:184: if (glist->gl_havewindow || x->x_isgopvisible)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">pddp/pddplink.c:99: if (glist_isvisible(glist) && glist->gl_havewindow)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">pddp/pddplink.c:152: if ((glist->gl_havewindow || x->x_isgopvisible)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">pddp/pddplink.c:180: if ((glist->gl_havewindow || x->x_isgopvisible)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">pddp/pddplink.c:249: if (glist->gl_havewindow || x->x_isgopvisible)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif"><br></font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">gl_mapped:</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/shared/hammer/file.c:447: return (f->f_canvas->gl_mapped);</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif"><br></font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">gl_loading:</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/shared/hammer/file.c:452: return (f->f_canvas->gl_loading);</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/shared/hammer/file.c:460: if (!cv->gl_loading)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">olafmatt/clone/clone.c:156: cv->gl_loading = 0;</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif"><br></font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">gl_edit:</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">bbogart/entry/entry.c:448: DEBUG(post("entry_click x:%d y:%d edit: %d", xpix, ypix, x->x_canvas->gl_edit);); </font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">bbogart/entry/entry.c:682: if( (x->x_glist->gl_edit) && (x->x_glist == x->x_canvas) )</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">ggee/gui/image.c:169: if ((glist_getcanvas(glist) != glist && !x->x_click) || (!glist->gl_edit && !x->x_click))</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/cyclone/hammer/comment.c:238: if (x->x_glist->gl_edit)</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/shared/toxy/scriptlet.c:345:<span class="" style="white-space:pre"> </span> sprintf(obuf, "%d", cv->gl_edit);</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">miXed/toxy/widget.c:935: int disable = (int)f && x->x_glist->gl_edit;</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">tkwidgets/text.c:355: DEBUG(post("textwidget_click x:%d y:%d edit: %d", xpix, ypix, x->x_canvas->gl_edit););</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif"><br></font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">gl_isgraph:</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">grill/trunk/flext/source/flattr_ed.cpp:795: if(!gl->gl_isgraph || gl->gl_havewindow) {</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">grill/trunk/flext/source/flattr_ed.cpp:828: if(!gl->gl_isgraph || gl->gl_havewindow) {</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">moonlib/mknob.c:135: if (!glist->gl_isgraph || glist_istoplevel(glist))</font></div><div class="gmail_default" style=""><font face="verdana, sans-serif">moonlib/mknob.c:243: if (!glist->gl_isgraph || glist_istoplevel(glist))</font></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 1, 2016 at 9:55 AM, Matt Barber <span dir="ltr"><<a href="mailto:brbrofsvl@gmail.com" target="_blank">brbrofsvl@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif">You're right, sorry. I was remembering this bit of code in moonlib/mknob.c, which accesses gl_isgraph:</div><div class="gmail_default" style="font-family:verdana,sans-serif"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif"><font color="#000000"><br></font></div><div class="gmail_default"><pre style="padding:10px;margin-top:0px;margin-bottom:0px;word-wrap:normal;border-left-width:1px;border-style:none none none solid;border-color:rgb(240,240,240);border-radius:0px;font-size:13px!important;line-height:1.5!important"><code style="font-size:inherit;padding:0px;border-radius:0px;word-wrap:normal;background-color:transparent"><font color="#000000" face="verdana, sans-serif"><span style="display:inline-block"> <span style="font-style:italic">/* GOP objects are unable to call findrtext triggering consistency check error */</span></span>
<span style="display:inline-block"> <span>t_rtext</span> <span>*</span><span>yyyy</span> <span>=</span> <span>NULL</span><span>;</span></span>
<span style="display:inline-block"> <span>if</span> <span>(</span><span>!</span><span>glist</span><span>-></span><span>gl_isgraph</span> <span>||</span> <span>glist_istoplevel</span><span>(</span><span>glist</span><span>))</span></span>
<span style="display:inline-block"> <span>yyyy</span> <span>=</span> <span>glist_findrtext</span><span>(</span><span>canvas</span><span>,</span> <span>(</span><span>t_text</span> <span>*</span><span>)</span><span>&</span><span>ob</span><span>-></span><span>ob_g</span><span>);</span></span>
<span style="display:inline-block"></span>
<span style="display:inline-block"> <span style="font-style:italic">/* on GOP we cause segfault as apparently text_gettag() returns bogus data */</span></span>
<span style="display:inline-block"> <span>char</span> <span>*</span><span>nlet_tag</span><span>;</span></span>
<span style="display:inline-block"> <span>if</span> <span>(</span><span>yyyy</span><span>)</span> <span>nlet_tag</span> <span>=</span> <span>rtext_gettag</span><span>(</span><span>yyyy</span><span>);</span></span>
<span style="display:inline-block"> <span>else</span> <span>nlet_tag</span> <span>=</span> <span>"bogus"</span><span>;</span></span></font></code></pre></div><div class="gmail_default" style="font-family:verdana,sans-serif"><br></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Fri, Jul 1, 2016 at 5:11 AM, IOhannes m zmölnig <span dir="ltr"><<a href="mailto:zmoelnig@iem.at" target="_blank">zmoelnig@iem.at</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><span>On 07/01/2016 04:34 AM, Matt Barber wrote:<br>
> This may also fix the moonlib knob problem.<br>
<br>
</span>which moonlib/knob problem?<br>
the only problem i'm aware of was that the "iemgui_all_colfromload" went<br>
missing in 0.47-0 (and made a re-appearance in 0.47-1).<br>
but this is unrelated to struct-members.<br>
<br>
gfmsadr<br>
<span><font color="#888888">IOhannes<br>
<br>
</font></span><br></div></div><span class="">_______________________________________________<br>
<a href="mailto:Pd-list@lists.iem.at" target="_blank">Pd-list@lists.iem.at</a> mailing list<br>
UNSUBSCRIBE and account-management -> <a href="https://lists.puredata.info/listinfo/pd-list" rel="noreferrer" target="_blank">https://lists.puredata.info/listinfo/pd-list</a><br>
<br></span></blockquote></div><br></div>
</blockquote></div><br></div>