[GEM-dev] [ pd-gem-Feature Requests-3468897 ] having more drawing style for primitive in Base/GemShape.cpp

[SourceForge.net]

Feature Requests item #3468897, was opened at 2012-01-03 02:54
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=507082&aid=3468897&group_id=64325

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Pending
Priority: 5
Private: No
Submitted By: Cyrille Henry (nusmuk)
Assigned to: Nobody/Anonymous (nobody)
Summary: having more drawing style for primitive in Base/GemShape.cpp

Initial Comment:
Thanks to the new vertexbuffer object, on can create a wild range of geometry. 
but the current rendering style are limited to : 
GL_LINE_LOOP, GL_POLYGON, GL_QUADS, GL_POINTS, GL_TRIANGLES, GL_TRIANGLE_STRIP;
This is a bit limiting. By example, the audio oscilloscope in the vertexbuffer help file would benefit being rendered as GL_LINE_STRIP better than GL_LINE_LOOP.
in fact, the missing rendering style are : 
GL_LINE, GL_LINE_STRIP,  GL_TRIANGLES_STRIP, GL_TRIANGLES_FAN and GL_QUADS_STRIP.

The implementation problem comes from the fact that only the 1st letter of the draw message was tested in order to discriminate from Line / points / triangle etc.
So adding more message may break backward compatibility.
Should we consider that "draw Lollipop" is not a legal message and should return an error, better than drawing Line_Loop?


----------------------------------------------------------------------

>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-01-03 05:25

Message:
i simplified the drawstyle logic a bit, by using a string->enum map, which
can be changed by objectclasses if they are not happy with the defaults
(which now includes almost all drawstyles you mention)
if the user provides an illegal draw-type, they get an error and a list of
all possible draw-styles.

the only missing drawstyle from the default set is GL_LINE (for backward
compat, "line" out to stay GL_LINE_LOOP), for which i have no good name; if
an objectclass really needs it, they could simply override the mapping from
"line" to GL_LINE.

pushed.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=507082&aid=3468897&group_id=64325