[GEM-dev] model bug: ignores normals in obj file

[IOhannes m zmoelnig]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-03-26 19:33, Claude Heiland-Allen wrote:
> Hi,
> 
> 
> diff --git a/plugins/modelOBJ/modelOBJ.cpp
> b/plugins/modelOBJ/modelOBJ.cpp index 4ff9d9e..be79716 100644 ---
> a/plugins/modelOBJ/modelOBJ.cpp +++
> b/plugins/modelOBJ/modelOBJ.cpp @@ -63,11 +63,13 @@ bool modelOBJ
> :: open(const std::string&name, const gem::Pro
> 
> glmFacetNormals (m_model);
> 
> +/* gem::Properties props=requestprops; 
> if(gem::Properties::UNSET==requestprops.type("smooth")) { 
> props.set("smooth", 0.5); } setProperties(props); +*/
> 

this does a bit too much, as it effectively disables "smooth" (and
other properties even if they *are* set).

i've just pushed a changeset, that will only try to automatically
smooth if the model doesn't yet contain normals.
i hope this is backwards compatible.

fgamsdr
IOhannes
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlFStEEACgkQkX2Xpv6ydvTIYACg97XO3qSu2KIDWQRY9veQ+LOY
utQAoI46gd9z1TnA9JkLqtQTEQvnuBS8
=w50S
-----END PGP SIGNATURE-----