[PD-dev] [ pure-data-Patches-1224730 ] pdsend bug with long(>127) sendbuffers

[SourceForge.net]

Patches item #1224730, was opened at 2005-06-21 02:04
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1224730&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: pdsend bug with long(>127) sendbuffers

Initial Comment:
in pdsend the length of the buffer is limited to 4096
chars.

however, in the send-routine, the buffer-length is
evaluated into a variable of type "char";
this prohibits the sending of buffers where
(char)strlen(buf)<0 (easy to reach, when working with
buffers longer than 127 chars)

this behaviour appears in all versions of pd<=0.38-4 (i
guess)

attached is a patch that uses "unsigned int" for the
length instead of "char"

NOTE: i guess the correct type should rather be "size_t"

NOTE: i think pdsend/netsend (and pdreceive/netreceive)
should really use the same code rather than 2 separate
copies.

----------------------------------------------------------------------

>Comment By: Miller Puckette (millerpuckette)
Date: 2005-07-15 17:22

Message:
Logged In: YES 
user_id=313747

Wow, that was stupid of me.  Thanks for catching it.  To
appear next CVS commit.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1224730&group_id=55736