[PD-dev] etiquette for closing sourceforge patches?

Hans-Christoph Steiner hans at eds.org
Sun Jan 1 20:17:05 CET 2006


On Jan 1, 2006, at 5:08 AM, Frank Barknecht wrote:

> Hallo,
> Miller Puckette hat gesagt: // Miller Puckette wrote:
>
>> What's proper etiquette for marking "patches" closed on sourceforge?   
>> Should
>> I be closing patches when I apply them to cvsmain or assuming the  
>> proposer will
>> do that?
>
> I'd say, the patches should be closed by you, if accepted or rejected.
> Another question: Are you also going through the Feature suggestion
> tracker [1]  sometimes? I recognized, that most of these aren't
> assigned to anybody. I allowed myself to add you as a possible "assign
> target" there as well now. ;) I hope, this is okay?
>
> [1] http://sourceforge.net/tracker/?group_id=55736&atid=478073

Personally, I don't think that Miller should close "Rejected" or other  
patches, only "Accepted".  Leaving non-Accepted patches open gives the  
patch submitter the opportunity to correct problems or update the  
patch.

.hc

________________________________________________________________________ 
____

  As we enjoy great advantages from inventions of others, we should be  
glad of an opportunity to serve others by any invention of ours; and  
this we should do freely and generously.
                                                                          
                          - Benjamin Franklin





More information about the Pd-dev mailing list