[PD-dev] s_loader bug in 0.40

[Hans-Christoph Steiner]

I was wondering what was going on, I noticed this in Pd-extended too, 
but never really looked into it.

Any chance you could fix packages/patches/loaderHEX-0.39-1.patch also? 
That is being used in Pd-0.39.2-extended.

.hc

IOhannes m zmoelnig wrote:
> hi miller, hi all.
> 
> i noticed that there is a small bug in my alternative classname loader
> code in s_loader.c, which prevents externals with a filename that needs
> to be escaped from being loaded.
> 
> such file will successfully be opened, however, since the brackets after
> the if statement are missing (line 81-92), the loader keeps believing
> that it failed.
> 
> the attached diff sets the brackets correctly.
> 
> 
> mf,.g.asdr
> IOhannes
> 
> 
> ------------------------------------------------------------------------
> 
> Index: s_loader.c
> ===================================================================
> RCS file: /cvsroot/pure-data/pd/src/s_loader.c,v
> retrieving revision 1.7
> diff -u -r1.7 s_loader.c
> --- s_loader.c	31 Dec 2005 20:55:25 -0000	1.7
> +++ s_loader.c	13 Mar 2006 15:35:55 -0000
> @@ -78,6 +78,7 @@
>              {
>                if ((fd = open_via_path(dirname, altname, sys_dllextent,
>                                        dirbuf, &nameptr, MAXPDSTRING, 1)) < 0)
> +                {
>  
>                  /* next try (alternative_classname)/(alternative_classname).(sys_dllextent) ... */
>                  strncpy(classname2, altname, MAXPDSTRING);
> @@ -89,6 +90,7 @@
>                                        dirbuf, &nameptr, MAXPDSTRING, 1)) < 0)
>                  {
>                    return 0;
> +                }
>                  } 
>              }
>            else
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> PD-dev mailing list
> PD-dev at iem.at
> http://lists.puredata.info/listinfo/pd-dev