[PD-dev] [ pure-data-Patches-1446663 ] sendOSC OSC type from PD atom type

[SourceForge.net]

Patches item #1446663, was opened at 2006-03-09 19:50
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1446663&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Martin Peach (mrpeach)
Assigned to: Nobody/Anonymous (nobody)
Summary: sendOSC OSC type from PD atom type

Initial Comment:
This patch fixes a problem arising when a user wishes
to send a number as a symbol and sendOSC converts it to
a float or int instead. This happens because sendOSC
converts all the arguments of a 'send' message to
string and then scans the string for numbers.
I changed the function ParseToken to ParseAtom, which
derives the OSC type directly from the PD atom type.
Floats and ints are distinguished by checking for
equality of the float and the int-converted-to-float.
This may cause further problems (e.g. if a user wishes
to transmit 1.000000 as a float) and it may be better
just to send all numbers as floats (or add specific
typetags to the send message?)

This patch also cleans out a lot of unused code.

Tested with Microsoft Visual C++ 2005 only (!) against
Pd version 0.39 TEST 7

Martin



----------------------------------------------------------------------

>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2006-04-18 11:31

Message:
Logged In: YES 
user_id=564396

i accepted these changes into the CVS (and tested it under
linux)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1446663&group_id=55736