[PD-dev] [ pure-data-Patches-1822007 ] hardcoded sample-type in jack-transport

SourceForge.net noreply at sourceforge.net
Mon Oct 29 11:19:21 CET 2007


Patches item #1822007, was opened at 2007-10-29 11:19
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1822007&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: hardcoded sample-type in jack-transport

Initial Comment:
in s_audio_jack.c the sample-type of the jack transportlayer is assumed to be "float", which is a naive assumption.
the correct type is "jack_default_audio_sample_t" (which might be either "float" or "double", depending on how jack was compiled)

the attached patch respects the type-definition of both jack and pd's own t_sample.
when the 2 types are the same, it just does a memcpy (this is similar as before, where it is assumed that both jack and pd use "float" internally)
when they are different, it copies the data manually.

LATER: improve the heuristic for finding out whether the two types are equal (currently only the sizeof() is checked)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1822007&group_id=55736




More information about the Pd-dev mailing list