[PD-dev] [ pure-data-Patches-1755710 ] patch: OS X sysexin/midiin support #2

[SourceForge.net]

Patches item #1755710, was opened at 2007-07-17 16:41
Message generated for change (Comment added) made by eighthave
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1755710&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Nathaniel Dose (dosena2)
Assigned to: Miller Puckette (millerpuckette)
Summary: patch: OS X sysexin/midiin support #2

Initial Comment:
Here is changed file 2 of 3 for enabling "sysexin" and "midiin". The changes are minimal; see below or attached. I was told to post here by the dev mailing list.

$ cvs status x_midi.c 
===================================================================
File: x_midi.c          Status: Locally Modified

   Working revision:    1.4
   Repository revision: 1.4     /cvsroot/pure-data/pd/src/x_midi.c,v
   Sticky Tag:          stable_0_40 (branch: 1.4.2)
   Sticky Date:         (none)
   Sticky Options:      (none)

$ cvs diff -u x_midi.c 
Index: x_midi.c
===================================================================
RCS file: /cvsroot/pure-data/pd/src/x_midi.c,v
retrieving revision 1.4
diff -u -r1.4 x_midi.c
--- x_midi.c    8 Sep 2006 23:45:31 -0000       1.4
+++ x_midi.c    17 Jul 2007 20:38:44 -0000
@@ -32,8 +32,8 @@
     x->x_outlet1 = outlet_new(&x->x_obj, &s_float);
     x->x_outlet2 = outlet_new(&x->x_obj, &s_float);
     pd_bind(&x->x_obj.ob_pd, midiin_sym);
-#ifndef __linux__
-    pd_error(x, "midiin: works under Linux only");
+#ifdef WIN32
+    pd_error(x, "midiin: windows: not supported");
 #endif
     return (x);
 }
@@ -55,8 +55,8 @@
     x->x_outlet1 = outlet_new(&x->x_obj, &s_float);
     x->x_outlet2 = outlet_new(&x->x_obj, &s_float);
     pd_bind(&x->x_obj.ob_pd, sysexin_sym);
-#ifndef __linux__
-    pd_error(x, "sysexin: works under Linux only");
+#ifdef WIN32
+    pd_error(x, "sysexin: windows: not supported");
 #endif
     return (x);
 }



----------------------------------------------------------------------

>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-24 19:05

Message:
Logged In: YES 
user_id=27104
Originator: NO

included in Pd-0.41-4

----------------------------------------------------------------------

Comment By: Mathieu Bouchard (matju)
Date: 2007-12-07 14:11

Message:
Logged In: YES 
user_id=801174
Originator: NO

accepted in desiredata last summer. I'm not super sure why, but desiredata
doesn't even have the "windows: not supported" part. Most likely I thought
that it wasn't [midiin]'s business to worry about platforms. anyway
nowadays in desiredata, a s_midi-like module can raise errors on behalf of
the object that used it, just using error(), and "find last error" will
find it, so, better put the platform-specific check as low-level as
possible (or rather, just at the level as the platform-specific thing is
happening, which in theory should be quite low-level)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1755710&group_id=55736