[PD-dev] [ pure-data-Patches-1755703 ] patch: OS X sysexin/midiin support

[SourceForge.net]

Patches item #1755703, was opened at 2007-07-17 16:35
Message generated for change (Settings changed) made by eighthave
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1755703&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Nathaniel Dose (dosena2)
Assigned to: Miller Puckette (millerpuckette)
Summary: patch: OS X sysexin/midiin support

Initial Comment:
Here is changed file 1 of 3 for enabling "sysexin" and "midiin". The changes are minimal; see below or attached. I was told to post here from the dev mailing list.

$ cvs status pmmacosxcm.c 
===================================================================
File: pmmacosxcm.c      Status: Locally Modified

   Working revision:    1.15.2.3
   Repository revision: 1.15.2.3        /cvsroot/pure-data/pd/portmidi/pm_mac/pmmacosxcm.c,v
   Sticky Tag:          stable_0_40 (branch: 1.15.2)
   Sticky Date:         (none)
   Sticky Options:      (none)



$ cvs diff -u pmmacosxcm.c 
Index: pmmacosxcm.c
===================================================================
RCS file: /cvsroot/pure-data/pd/portmidi/pm_mac/pmmacosxcm.c,v
retrieving revision 1.15.2.3
diff -u -r1.15.2.3 pmmacosxcm.c
--- pmmacosxcm.c        19 Jan 2007 04:30:56 -0000      1.15.2.3
+++ pmmacosxcm.c        17 Jul 2007 20:31:11 -0000
@@ -456,6 +456,14 @@
     if (m->sysex_timestamp < m->last_time) m->sysex_timestamp = m->last_time;
     
     /* now send what's in the buffer */
+    if (m->packet == NULL) {
+        /* if flush has been called in the meantime, packet list is NULL */
+        m->packet = MIDIPacketListInit(m->packetList);
+        /* this can never fail, right? failure would indicate something 
+           unrecoverable */
+        assert(m->packet);
+    }
+
     err = send_packet(midi, m->sysex_buffer, m->sysex_byte_count,
                       m->sysex_timestamp);
     m->sysex_byte_count = 0;


----------------------------------------------------------------------

Comment By: Mathieu Bouchard (matju)
Date: 2007-12-07 14:15

Message:
Logged In: YES 
user_id=801174
Originator: NO

desiredata does not bundle PortMIDI. Is this patch something that is
available in the latest official PortMIDI ? I'd rather not use a custom
PortMIDI if possible, but if again it's not possible to be well served with
official releases, I don't mind forking PortMIDI again (it was unforked by
devel_0_39, which is why it's not in desiredata; i didn't make that
decision cause I don't really know about this topic)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1755703&group_id=55736