[PD-dev] [ pure-data-Patches-1953853 ] fix for empty GOP draws red rect on parent

[SourceForge.net]

Patches item #1953853, was opened at 2008-04-28 23:40
Message generated for change (Comment added) made by eighthave
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1953853&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jakob Leben (jleben)
>Assigned to: Miller Puckette (millerpuckette)
>Summary: fix for empty GOP draws red rect on parent

Initial Comment:
This patch fixes the following bug:
The "graph on parent" red rectangle is drawn on the parent patch when an object is created in a subpatch by sending it a message after the subpatch has been set to GOP but it's window has been closed before any objects had been created in it.

This is a patch against pd-0.41-4.

--- pd2patch-orig/g_graph.c     2008-03-15 01:03:00.000000000 +0100
+++ pd2patch-leben/g_graph.c    2008-04-29 01:53:17.000000000 +0200
@@ -43,7 +43,7 @@
         && pd_checkobject(&y->g_pd))
     {
         x->gl_goprect = 1;
-        canvas_drawredrect(x, 1);
+        if(x->gl_havewindow) canvas_drawredrect(x, 1);
     }
     if (glist_isvisible(x))
         gobj_vis(y, x, 1);


----------------------------------------------------------------------

>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-05-01 08:53

Message:
Logged In: YES 
user_id=27104
Originator: NO

added patch to demonstrate the bug, and added the patch to
branches/pd-extended/0.40
File Added: red_rect_on_parent_bug.pd

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1953853&group_id=55736