[PD-dev] [ pure-data-Patches-1953853 ] fix for empty GOP draws red rect on parent

SourceForge.net noreply at sourceforge.net
Wed Mar 18 19:51:28 CET 2009


Patches item #1953853, was opened at 2008-04-29 03:40
Message generated for change (Comment added) made by sf-robot
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1953853&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Jakob Leben (jleben)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix for empty GOP draws red rect on parent

Initial Comment:
This patch fixes the following bug:
The "graph on parent" red rectangle is drawn on the parent patch when an object is created in a subpatch by sending it a message after the subpatch has been set to GOP but it's window has been closed before any objects had been created in it.

This is a patch against pd-0.41-4.

--- pd2patch-orig/g_graph.c     2008-03-15 01:03:00.000000000 +0100
+++ pd2patch-leben/g_graph.c    2008-04-29 01:53:17.000000000 +0200
@@ -43,7 +43,7 @@
         && pd_checkobject(&y->g_pd))
     {
         x->gl_goprect = 1;
-        canvas_drawredrect(x, 1);
+        if(x->gl_havewindow) canvas_drawredrect(x, 1);
     }
     if (glist_isvisible(x))
         gobj_vis(y, x, 1);


----------------------------------------------------------------------

>Comment By: SourceForge Robot (sf-robot)
Date: 2009-03-18 18:51

Message:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-01-12 18:00

Message:
looking at g_graph.c in trunk, this patch wasn't accepted, but the bug
doesn't happen in 0.42.2.  Anyone know how it was fixed?

----------------------------------------------------------------------

Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2009-01-12 16:24

Message:
seems to be accepted (or fixed) in 0.42

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-05-01 12:53

Message:
Logged In: YES 
user_id=27104
Originator: NO

added patch to demonstrate the bug, and added the patch to
branches/pd-extended/0.40
File Added: red_rect_on_parent_bug.pd

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1953853&group_id=55736




More information about the Pd-dev mailing list