[PD-dev] [ pure-data-Patches-1930681 ] 0.41-4 s_path.c fixes

[SourceForge.net]

Patches item #1930681, was opened at 2008-03-31 23:44
Message generated for change (Comment added) made by sf-robot
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930681&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
Assigned to: Miller Puckette (millerpuckette)
Summary: 0.41-4 s_path.c fixes

Initial Comment:
Two fixes for buffer overrun (buf[1000]=0 later) and rc file args:


--- s_path.ori.c	2008-04-01 01:37:03.000000000 +0200
+++ s_path.c	2008-04-01 01:38:02.000000000 +0200
@@ -379,7 +379,7 @@
     int rcargc;
     char* rcargv[NUMARGS];
     char* buffer;
-    char  fname[MAXPDSTRING], buf[1000], *home = getenv("HOME");
+    char  fname[MAXPDSTRING], buf[1001], *home = getenv("HOME");
     int retval = 1; /* that's what we will return at the end; for now, let's think it'll be an error */
  
     /* initialize rc-arg-array so we can safely clean up at the end */
@@ -423,7 +423,7 @@
     fclose(file);
     if (sys_verbose)
     {
-        if (rcargv)
+        if (rcargc)
         {
             post("startup args from RC file:");
             for (i = 1; i < rcargc; i++)



----------------------------------------------------------------------

>Comment By: SourceForge Robot (sf-robot)
Date: 2009-03-18 18:51

Message:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2009-01-12 16:32

Message:
seems to be fixed (though slightly different) in 0.42

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 23:59

Message:
Logged In: YES 
user_id=27104
Originator: NO

checked into branches/pd-extended/0.40

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930681&group_id=55736