[PD-dev] [ pure-data-Patches-2584887 ] bonk ignores relative paths when reading templates

SourceForge.net noreply at sourceforge.net
Tue Aug 3 06:15:41 CEST 2010


Patches item #2584887, was opened at 2009-02-10 04:12
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2584887&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Frank Barknecht (fbar)
Assigned to: Miller Puckette (millerpuckette)
Summary: bonk ignores relative paths when reading templates

Initial Comment:
bonk~ can not open previously stored attack templates when only a relative path is supplied to the "read templates.txt" message. 

bonk~ also ignores any [declare] declarations when searching for template files and only works with absolute paths or templates in the working directory PPd was started from.

----------------------------------------------------------------------

Comment By: Frank Barknecht (fbar)
Date: 2010-01-02 03:20

Message:
You're right, it's the same issue as patch 1242459, I hadn't seen that one.
However bonk~.c has changed significantly in the meantime. I'm not sure, if
the old patch can still be applied automatically.

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 17:35

Message:
This seems like it might be a duplicate of patch #1242459

https://sourceforge.net/tracker/?func=detail&aid=1242459&group_id=55736&atid=478072

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-02-15 20:29

Message:
one detail: MAXPDSTRING is longer than FILENAME_MAX on Windows, so to
prevent crasher bugs, any time a file path is stored, FILENAME_MAX should
be used instead of MAXPDSTRING.

----------------------------------------------------------------------

Comment By: Frank Barknecht (fbar)
Date: 2009-02-10 08:07

Message:
Okay, attached is a patch that changes the "read" and "write" messages to
use canvas-relative paths. Tested only briefly, but seems to work. Diff
against current SVN HEAD.
File Added: bonk~.c.diff

----------------------------------------------------------------------

Comment By: Frank Barknecht (fbar)
Date: 2009-02-10 04:19

Message:
bonk~ should probably use the canvas_open() method to open files instead of
a plain fdopen()

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2584887&group_id=55736



More information about the Pd-dev mailing list