[PD-dev] [ pure-data-Patches-3050325 ] pdp_mix perfect copy for crossfade=1: portable (mmx)

[SourceForge.net]

Patches item #3050325, was opened at 2010-08-21 11:08
Message generated for change (Settings changed) made by eighthave
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3050325&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: whyameye (whyameye)
>Assigned to: Hans-Christoph Steiner (eighthave)
Summary: pdp_mix perfect copy for crossfade=1: portable (mmx)

Initial Comment:
when crossfade is set to 1 for [pdp_mix], outlet should return exact copy of middle inlet. Instead [pdp_mix] still tries to mix the left and middle inlet, resulting in slight degradation of the resulting video. Consequently, a feedback loop connecting [pdp_mix] outlet to its middle inlet through a [pdp_del] with crossfade set to 1 will eventually result in a video that is completely black.

This patch adds a trivial copy from the middle inlet to the outlet if the crossfade is set to 1. This patch works for the  mmx version of the code. The portabkle (no mmx) version of the code has the same flaw and the patch for this has been submitted with ID 3050324


----------------------------------------------------------------------

>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-09-08 21:09

Message:
accepted with this commit:

http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revision=14003

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3050325&group_id=55736