[PD-dev] [ pure-data-Patches-3079466 ] tk 8.5 font fix ought to apply to 8.6 too

[SourceForge.net]

Patches item #3079466, was opened at 2010-10-01 10:29
Message generated for change (Comment added) made by eighthave
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3079466&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Pending
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: tk 8.5 font fix ought to apply to 8.6 too

Initial Comment:
Index: pd.tk
===================================================================
--- pd.tk       (révision 14147)
+++ pd.tk       (copie de travail)
@@ -133,10 +134,10 @@

 # Pd-0.39.2-extended hacks to make font/box sizes the same across platform
 puts stderr "tk scaling is [tk scaling]"
-tk scaling 1
+#tk scaling 1

 # for some reason, the fonts are bigger in Tcl/Tk 8.5 than 8.4
-if {$pd_nt != 1 && $::tcl_version eq "8.5"} {
+if {$pd_nt != 1 && [string compare $::tcl_version "8.5"] >= 0} {
        set console_font_size 9
 } else {
        set console_font_size 12
@@ -4020,7 +4023,7 @@
        if {$pd_nt == 1} { raise . }

     set fontlist ""
-       if {$pd_nt != 1 && $::tcl_version eq "8.5"} {
+       if {$pd_nt != 1 && [string compare $::tcl_version "8.5"] >= 0} {
                set sizelist "5 6 8 9 10 12 14 16 19 25"
        } else {
                set sizelist "8 9 10 12 14 16 18 24 30 36"


----------------------------------------------------------------------

>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-10-05 05:45

Message:
this patch should be submitted against 0.43, like IOhannes said, also, tk
scaling needs to be hard-coded to 1 until pd itself no longer handles the
mouse clicks

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2010-10-04 15:10

Message:
With Pd-0.43-0test2, the >= is already in use, so, you are right.

And when I try it, it works, because now the fonts are too small instead.

----------------------------------------------------------------------

Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2010-10-01 16:06

Message:
with pd>=0,43 the gui-code has been refactored.
could you please check whether the problem is stil there (e.g. check out
the latest and greatest code via git), and if so, provide a patch for the
current code (preferrably using git, e.g. as described at
http://puredata.info/docs/developer/GitWorkflows)?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3079466&group_id=55736