[PD-dev] [ pure-data-Patches-3102512 ] [bugfix] jack sample rate autodetection

[SourceForge.net]

Patches item #3102512, was opened at 2010-11-03 17:19
Message generated for change (Comment added) made by ico_bukvic
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3102512&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ivica Ico Bukvic (ico_bukvic)
Assigned to: Miller Puckette (millerpuckette)
Summary: [bugfix] jack sample rate autodetection

Initial Comment:
In Pd and Pd-extended 0.42.5 Jack Audio Settings menu's sample rate always defaults to 44100Hz so one has to manually change it to the proper sampling rate JACK or otherwise everything sounds off-pitch when one presses apply in situations when JACK is not running at 44100Hz. Following patch fixes this problem and also automatically adjusts to changes, so that the only thing one has to do when reconnecting to JACK (assuming number of channels remains the same) is to simply restart dsp by pressing the "compute audio" button on the main PD window.

----------------------------------------------------------------------

Comment By: Ivica Ico Bukvic (ico_bukvic)
Date: 2010-11-04 19:33

Message:
OK, added ifdefs so that should be hopefully it.

This patch is mainly for the 0.42 branch. Should patch cleanly against
0.42.5 extended and I suspect also regular pd vanilla of the same version.
I am not sure what is the state of 0.43 as we've not moved to that version
yet.

----------------------------------------------------------------------

Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2010-11-04 04:40

Message:
is this still the case with Pd-0.43 (vanilla)? i think it is fixed there.

also please note that your patch seems to lack an ifdef guard, so it might
fail to link and/or run on systems that are compiled without jack-support.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3102512&group_id=55736