[PD-dev] general makefile question

[Hans-Christoph Steiner]

On Dec 2, 2010, at 4:16 AM, IOhannes m zmoelnig wrote:

> On 2010-12-01 23:56, Albert Graef wrote:
>> IOhannes m zmölnig wrote:
>>> however, afaict, CFLAGS and LDFLAGS are commonly meant to be  
>>> settable by
>>> the user, so setting those should not break the build system.
>>
>> Exactly. Therefore a Makefile should *not* set CFLAGS, CXXFLAGS,  
>> LDFLAGS
>> and the like, or only set them to some reasonable defaults which  
>> can be
>> freely overridden by the user. Of course this means that build- 
>> specific
>> options must be passed in the corresponding Makfile rules in  
>> addition to
>> these variables.
>
> finarlly someone who understands me!
>
>>
>> This is only a convention, of course, but it's part of the GNU Coding
>> Standards
>
> ha, thank you very much for the pointer.
> i think the curcial part is:
> "If there are C compiler options that must be used for proper
> compilation of certain files, do not include them in CFLAGS. Users
> expect to be able to specify CFLAGS freely themselves."
>
> and i think this can also be extrapolated for any of the standard  
> flags
> (CPPFLAGS, CFLAGS, CXXFLAGS, LDFLAGS)


So what do you propose?  I for one am really sick of build system  
stuff.  What we have works quite well on many platform, but yes, its  
not perfect.  About changes to the template Makefile, last time  
IOhannes you changed it, you didn't test it well and it had a bug  
where the help files didn't get included and it didn't throw and  
error.  That caused me to have to re-issue Pd-extended releases to  
make sure all the help patches were included, which I was not happy  
about.

So basically, if anyone wants to improve the template Makefile, that's  
good, but they need to _thoroughly_ test all changes to it on multiple  
platforms.  Really, the way to do it is to do these changes as part of  
a library, then once they are well tested and ironed out, include them  
in the template Makefile.

.hc

----------------------------------------------------------------------------

"We have nothing to fear from love and commitment." - New York Senator  
Diane Savino, trying to convince the NY Senate to pass a gay marriage  
bill