[PD-dev] [PATCH] Replace getbytes calls by alloca whenever possible in mrpeach's packOSC.c

[Julien 'Lta' BALLET]

Om(f)g,

I forgot to join the patch. He's on my work computer. I'll send it tomorrow

--
Lta.

On Sun, Dec 12, 2010 at 7:10 PM, Martin Peach <martin.peach at sympatico.ca>wrote:

> Hi Lta,
>
> Did you post the patch somewhere? I can't find it.
>
> Martin
>
>
>
> On 2010-12-12 12:49, Julien 'Lta' BALLET wrote:
>
>> Hello,
>>
>> I can't test on other platform than on Linux, so some help testing this
>> would be appreciated, but this functions is available at least under
>> windows, and osx. The semantic is the same on all the platforms,
>> according to the documenation. I've included the correct header on
>> windows, unix and osx.
>>
>> --
>> Lta.
>>
>> On Sun, Dec 12, 2010 at 3:52 PM, patko <colet.patrice at free.fr
>> <mailto:colet.patrice at free.fr>> wrote:
>>
>>    Hello, is your patch working on all platforms?
>>
>>
>>    ----- "Julien 'Lta' BALLET" <elthariel at gmail.com
>>    <mailto:elthariel at gmail.com>> a écrit :
>>
>>
>>     > Hello,
>>     >
>>     >
>>     > Good question indeed. This is a general improvement. Sorry for not
>>     > explaining it in the first place, this is my first post and patch on
>>     > the pd-dev ml.
>>     >
>>     >
>>     > --
>>     > Lta
>>     >
>>     >
>>     > On Fri, Dec 10, 2010 at 5:01 PM, Hans-Christoph Steiner <
>>     > hans at at.or.at <mailto:hans at at.or.at> > wrote:
>>     >
>>     >
>>     >
>>     > My first question is: what's the problem that you are trying to
>>    solve?
>>     > Are there specific bugs, or just a general improvement?
>>     >
>>     > .hc
>>     >
>>     >
>>     >
>>     >
>>     > On Dec 10, 2010, at 8:50 AM, Julien 'Lta' BALLET wrote:
>>     >
>>     >
>>     >
>>     >
>>     >
>>     >
>>     > Hello,
>>     >
>>     > As said in the title, i submit you a small patch to mrpeach's osc
>>     > code, to replace calls to getbytes by alloca calls in part of the
>>    code
>>     > that might get called in the soundcard callback.
>>     >
>>     > The considered memory sizes are quites small and then won't smash
>> the
>>     > stack. This removes the need for memory deallocation and reduces the
>>     > page fault risk as well as the memory allocation time.
>>     >
>>     > This is kind of a naive patch, since i don't fully know yet the pd
>>     > codebase.
>>     >
>>     > Any comment would be appreciated.
>>     >
>>     > Regards,
>>     > Lta.
>>     > _______________________________________________
>>     > Pd-dev mailing list
>>     > Pd-dev at iem.at <mailto:Pd-dev at iem.at>
>>
>>     > http://lists.puredata.info/listinfo/pd-dev
>>     >
>>     >
>>     >
>>     >
>>
>>  ----------------------------------------------------------------------------
>>     >
>>     > Computer science is no more related to the computer than astronomy
>> is
>>     > related to the telescope. -Edsger Dykstra
>>     >
>>     >
>>     >
>>     >
>>     > _______________________________________________
>>     > Pd-dev mailing list
>>     > Pd-dev at iem.at <mailto:Pd-dev at iem.at>
>>
>>     > http://lists.puredata.info/listinfo/pd-dev
>>
>>    --
>>    Patrice Colet
>>
>>
>>
>>
>> _______________________________________________
>> Pd-dev mailing list
>> Pd-dev at iem.at
>> http://lists.puredata.info/listinfo/pd-dev
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.puredata.info/pipermail/pd-dev/attachments/20101212/6d619cae/attachment.htm>