[PD-dev] [ pure-data-Patches-3160988 ] [bugfix] array boundaries

[SourceForge.net]

Patches item #3160988, was opened at 2011-01-18 18:24
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3160988&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata
>Group: None
Status: Open
Resolution: None
Priority: 6
Private: No
Submitted By: IOhannes m zmlnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
>Summary: [bugfix] array boundaries

Initial Comment:
in Pd-0.43 the table boundaries do not work.

to reproduce:
- create a new array (keep everything default)
- draw something into the array
- right-click the array to go to properties
- close the "array properties", we only want to modify the "canvas properties"
- change (e.g.) the Y-range from 1,-1 to 1,0
- click on Apply
- the table content vanishes
- the pd-console prints 5 times "shouldvis 0: array" 

you cannot draw anything in the array anymore (nor see the contents)
whenever you move the mouse over the array a "shouldvis 0: array" is printed

save/open does not help

----------------------------------------------------------------------

>Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2011-01-19 15:25

Message:
ooh, that was ugly...

it turns out that the problem was following:
if, after changing the boundaries, table values would be out of the
graph's rectangle, the graph would refuse to update.

attached patch fixes this by adding garray_class to the exceptions (like
scalar_class), that are displayed regardless of whether they go
out-of-bounds.

i reason that this is acceptable, as the current state of affairs (without
my patch) would allow the user to draw in the array und thus create
out-of-bounds values: when they save the patch (with
"save-contents-of-array" enabled) and re-open the patch, all values are
invisible!

----------------------------------------------------------------------

Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2011-01-19 11:13

Message:
btw, the "bounds" message to the array is working as expected.

----------------------------------------------------------------------

Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2011-01-19 10:20

Message:
forgot to specify my used Pd-version: 0.43-test4 (ceb8db7372)

since millers commit f5cabbb531cdee, the "shouldvis" message has obviously
disappeared, but the problem with arrays not displaying their content
persists.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3160988&group_id=55736