[PD-dev] [ pure-data-Patches-3177183 ] readanysf~ makefile fixes

[SourceForge.net]

Patches item #3177183, was opened at 2011-02-10 10:14
Message generated for change (Tracker Item Submitted) made by zmoelnig
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3177183&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmlnig (zmoelnig)
Assigned to: Nobody/Anonymous (nobody)
Summary: readanysf~ makefile fixes

Initial Comment:
while packaging readanysf~ for debian, i had to apply several fixes to make this work cleanly.

here are the issues:
#1 temporary .o files are stored in a ./objs/ directory, which does not exist in the released package (i see it is in SVN though)
  i added rules to the makefile to create this directory if non-existant (and delete it on "clean" as debian doesn't like it if  "clean"  leaves traces around)

#2 the Makefile sets CFLAGS (and LDFLAGS); these common variables are frequently overriden by build-systems (such as the debian package builder); since the flags in the CFLAGS are crucial for successfull builds, overriding these flags will break the build-system.
 i fixed it so the Makefiloe uses PD_CFLAGS and append (the unset) CFLAGS to this variable: this way users can define their preferred optimization using CFLAGS and the build will still succeed
(btw, you should actually use PD_CXXFLAGS/CXXFLAGS for c++ flags)

#3 you are setting "-fPIC" conditionally only for 64bit systems; is there a reason to not use it on all systems (including 128bit)? debian builds on a zillion of platforms and usually "-fPIC" is applied throughout.

#4 OS-detection code only handles Linux & Darwin; bad thing here is, that it assumes everything Darwin that is not Linux;
afaics, this is meant as a boolean discrimination (you don't really expect UNAME to be not "Darwin" on any OSX, do you?), which i inverted (so that everything is Linux that is not Darwin): this is important on Debian as UNAME might be "Linux", "GNU/kFreeBSD" or "GNU"(Hurd) and everything is dealt the same.

it would be nice if these changes could be incorporated into upstream.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3177183&group_id=55736