[PD-dev] [ pure-data-Patches-3189135 ] glob_evalfile returns reference *

[SourceForge.net]

Patches item #3189135, was opened at 2011-02-22 03:17
Message generated for change (Comment added) made by reakin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3189135&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Rich E (reakin)
Assigned to: Nobody/Anonymous (nobody)
Summary: glob_evalfile returns reference *

Initial Comment:
glob_evalfile returns a reference to the patch that it opens, which is useful when opening/closing patches with a system other than the messaging (pd open ....) system.  We are already using this system in libpd to open and close patches by reference instead of file name, and this also allows us to know more about the patch at instantiation (ex. dollar args).  

As the method glob_evalfile currently returns void, it has no backwards incompatibility issues.  

----------------------------------------------------------------------

Comment By: Rich E (reakin)
Date: 2011-02-24 04:16

Message:
Please look at the updated diff file, I have removed all the tabs and
inserted white spaces instead (sorry, its my ide's fault not mine).  

The brackets around the while statement are preferred, as we want to
return x when it is still valid, not assign it a new value at each
iteration (at which point the loop ends when x == null).

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-02-23 21:05

Message:
Sounds like a reasonable patch, but the diff itself is fully of whitespace
changes, so its quite hard to read.  A patch should only have relevant
changes in it.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3189135&group_id=55736