[PD-dev] [ pure-data-Patches-3109768 ] [bugfix] gop patch name uneditable after disabling gop

[SourceForge.net]

Patches item #3109768, was opened at 2010-11-15 16:10
Message generated for change (Comment added) made by jancsika1
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3109768&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ivica Ico Bukvic (ico_bukvic)
Assigned to: Miller Puckette (millerpuckette)
Summary: [bugfix] gop patch name uneditable after disabling gop

Initial Comment:
Last lingering GOP bug (after all previous GOP bugfixes that I submitted have been applied). Namely, when:

1) open a new patch and create [pd something]
2) right-click on object's properties, enable both GOP and "hide text" options and click on OK/Apply
3) the object will revert to its original object-like appearance and will be open-able but its name (text) will not be editable
4) right-clicking on its properties shows that both "hide text" and GOP are still enabled

This is because disabling GOP function does not reset hidetext variable. Following patch fixes this.

----------------------------------------------------------------------

Comment By: Jonathan Wilkes (jancsika1)
Date: 2011-07-07 12:46

Message:
There's still a problem:
5) Uncheck "hide text", then uncheck "Graph on parent". Now text is not
editable.

Alternatively, unchecking "Graph on parent" without unchecking "hide text"
will not revert the subpatch to an object box.

Test with Pd 0.43.0 on Maverick.

----------------------------------------------------------------------

Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2011-02-08 06:15

Message:
i attached a simple fix for the problem that deals with it in the tcl
domain.
this applies (only) to 0.43.

file: 0001-disabling-GOP-should-also-disable-hidetext.patch
created for 0.43.0test4

this obsoletes ico's "gop_patch_20101115" (which i leave here for
reference)

----------------------------------------------------------------------

Comment By: Ivica Ico Bukvic (ico_bukvic)
Date: 2010-11-15 16:11

Message:
Forgot to mention, this applies to 0.42.5 branch of both pd and
pd-extended. It has not been tested against 0.43.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3109768&group_id=55736