[PD-dev] [ pure-data-Patches-3380575 ] [makefilename] patch reliably segfaults

[SourceForge.net]

Patches item #3380575, was opened at 2011-07-27 20:17
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3380575&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Chris McCormick (chr15m)
Assigned to: Miller Puckette (millerpuckette)
Summary: [makefilename] patch reliably segfaults

Initial Comment:
Attached is a patch that reliably segfaults Pd.

----------------------------------------------------------------------

>Comment By: Miller Puckette (millerpuckette)
Date: 2011-07-30 13:47

Message:
This is rather confusingly written (and badly indented)... I'd suggest
having makefilename_scanformat()
simply scan through the string in one pass.  I can hack on this later if
necessary.

----------------------------------------------------------------------

Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2011-07-28 03:49

Message:
attached is a patch that checks whether there are multiple format
specifiers, and if so, complains and refuses to work.
this effectively prevents the crash (though it still does not enable
multiple format specifiers)

the patch applies to todays git master.
raised priority since it is a crasher bug.

----------------------------------------------------------------------

Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2011-07-28 03:46

Message:
while the docs are a bit confusion about this, [makefilename] really can
only handle a _single_ format specifier;

so using a format-string like "%s-%s" is illegal.

however, Pd should never segfault

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3380575&group_id=55736