[PD-dev] [ pure-data-Patches-3591846 ] portaudio fixes

[SourceForge.net]

Patches item #3591846, was opened at 2012-12-02 08:56
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3591846&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 9
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: portaudio fixes

Initial Comment:
this patches fixes the current portaudio implementation.

since it is too big to be added to the patch-tracker (i imported portaudio-20121129), you can download it from http://iem.at/~zmoelnig/0001-updated-to-portaudio-20121129-snapshot.patch.bz2

----------------------------------------------------------------------

>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-03 10:05

Message:
I tried this and got:

[msp at fuzz pd]$ git apply
~/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:287:
trailing whitespace.
   
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:300:
trailing whitespace.
   
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:336:
trailing whitespace.
 * The text above constitutes the entire PortAudio license; however, 
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:341:
trailing whitespace.
 * they can be incorporated into the canonical version. It is also 
/home/msp/bis/var/download/0001-updated-to-portaudio-20121129-snapshot.patch:342:
trailing whitespace.
 * requested that these non-binding requests be included along with the 
warning: squelched 32389 whitespace errors
warning: 32394 lines add whitespace errors.

... is there any way you can supply a patch that doens't add trailing white
space to 1/2 ot the Pd
source?

thanks
M

----------------------------------------------------------------------

Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-12-02 09:07

Message:
raising priority, since the current state of affairs breaks all builds from
current git.

what i did:
- after the import of the portaudio-20121101  snapshot, some files where
missing to smoothly integrate with Pd's autotools system.
- so I re-imported portaudio with the missing files (and used the 20121126
snapshot, since that was the one i found on the portaudio website)
- I tried to keep the import to a minimum (but imported all files an
ordinary make would want to run a compilation)
- i added the new portaudio build-system to pd/configure.ac (so pa's
configure will get called automatically by Pd's configure)
- i also adjusted the link-path of libportaudio in pd/src/Makefile.am to
it's new location

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3591846&group_id=55736