[PD-dev] [ pure-data-Patches-3591846 ] portaudio fixes

[Miller Puckette]

Aha... so all the whitespace trouble was their fault, not yours :)

Anyhow, it's on the tracker, but you can get the one I was using:

http://crca.ucsd.edu/~msp/tmp/pa_snapshot_20121031.tgz

but I'd sort of rather not haul all the examples, tests, qa, and wierd
APIs into the Pd tree if there's any smooth way to avoid that - can it be
done by making minor adjustments to makefiles in Pa insteadby any chance?

thanks
M

On Mon, Dec 03, 2012 at 07:17:21PM +0100, IOhannes m zmoelnig wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 2012-12-03 19:05, SourceForge.net wrote:
> > 
> >> Comment By: Miller Puckette (millerpuckette)
> > Date: 2012-12-03 10:05
> > 
> > Message: I tried this and got:
> > 
> [...]
> > 
> > ... is there any way you can supply a patch that doens't add
> > trailing white space to 1/2 ot the Pd source?
> > 
> > thanks M
> > 
> 
> hi miller.
> 
> for what it is worth, my usual workflow now includes a whitespace
> checker, so i don't incidentally submit patches with whitespaces any
> more (i simply enabled the pre-commit hook in my .git/hooks/).
> this has been active for some time now (on all machines i currently
> develop on)
> 
> otoh, the trailing whitespace in _this_ patch was intended, in order
> to keep the portaudio sources as untouched as possible.
> the portaudio source base doesn't seem to care at all, whether they
> have lines ending with whitespace or not.
> afaict, your original portaudio import also contains trailing
> whitespace (at least that's how i discovered that in order to keep the
> patch-set minimal, i should preserve the trailing whitespaces).
> 
> if you would prefer, i could prepare another import of portaudio
> without trailing whitespaces.
> 
> 
> fg,asdr
> IOhannes
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.12 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
> 
> iEYEARECAAYFAlC87K4ACgkQkX2Xpv6ydvT5lQCeIVbZtcj0X2r49wxIiSDW4LR3
> dFAAn1T2CUMbw1SLCRIA0nVT7/Qid98V
> =3CjY
> -----END PGP SIGNATURE-----
> 
> _______________________________________________
> Pd-dev mailing list
> Pd-dev at iem.at
> http://lists.puredata.info/listinfo/pd-dev