[PD-dev] [ pure-data-Patches-3594735 ] Win32: unicode support for files with public API for externs

[SourceForge.net]

Patches item #3594735, was opened at 2012-12-10 19:14
Message generated for change (Comment added) made by eighthave
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_id=55736

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: Win32: unicode support for files with public API for externs

Initial Comment:
Right now, Pd on Windows does really badly if there are any non-ASCII characters in the path or filename.  It makes it freeze for a while, and sometimes crashes it.  These patches fix that.

Pd and Tcl/Tk is UTF-8 internally, and UNIXes all use UTF-8 for filenames
and paths.  Windows uses UCS-2 everywhere, which is a 16-bit format.  The
only place this affects Pd is reading and writing filenames, and printing
to the console.  The POSIX-style functions open() and fopen() exist on
Windows, but only work for ASCII filenames.  To support Unicode filenames,
we have to convert the UTF-8 to UCS-2, then use Win32-specific functions.

Since any external that opens files will also be affected the same
way, this patch provides a public API: sys_open()/sys_close(), and
sys_fopen()/sys_fclose().  For non-Win32 platforms, they are just
names that point to the normal POSIX versions.  On Win32, they are
special functions to handle UTF-8 to UCS-2 conversion.

I have built and run this on Windows XP, Mac OS X 10.6, and Debian/squeeze amd64.  These patches are also included in Pd-extended 0.43.4.


----------------------------------------------------------------------

>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 21:44

Message:
These are all the externals in Pd-extended that need changes to support
Unicode filenames:

http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revision=16669
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revision=16670
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revision=16671

Basically, you just need to change open() to sys_open() and fopen() to
sys_fopen().  You can remove sys_bashfilename() since its included in those
new open functions when needed.

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 21:25

Message:
and a couple more for good measure ;)

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 19:37

Message:
I added a fifth patch. Microsoft says that the POSIX close() was deprecated
in 2005, and to use
their ISO C++ _close() instead.

http://msdn.microsoft.com/en-US/library/ms235443(v=vs.80).aspx
http://msdn.microsoft.com/en-US/library/5fzwd5ss(v=vs.80).aspx

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_id=55736