[PD-dev] Win32 - unicode support for files, with public API for externals

IOhannes m zmoelnig zmoelnig at iem.at
Mon Dec 17 10:55:39 CET 2012


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

the recent commit 78b81aa3cb90 on the puredata/master branch breaks
ABI compatibility with externals compiled for Pd-0.43.

the problem is that the "sys_close()" symbol is removed for non-w32
platforms.
therefore all the externals on non-w32 that (already) use sys_close()
(at least i have written a couple of them) will fail to load with a
new version of Pd, unless they are recompiled.

this makes packaging externals for e.g. Debian a nightmare, as it
basically should trigger a .so-name change, but since we are linking
against the application instead of an ordinary library, all the tools
that would detect such an incompatibility will fail.


so please revert the "#define sys_close close" stanzas.


instead i would ask you to provide sys_open() (and friends)
implementations in s_path, even for platforms where they are mere
wrappers around the system functions.

it also makes the header-file much easier to read (i don't think
anything in a public header-file but function decorations should be
ifdef'ed)

fgamsdr
IOhannes
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlDO7BgACgkQkX2Xpv6ydvTMIQCfYM+ifUeF2H3Bgh/o5C4S2vuz
kBEAnjfhlPz5jlU1KEIoZbAumtYF++B7
=maMx
-----END PGP SIGNATURE-----



More information about the Pd-dev mailing list