[PD-dev] [ pure-data-Patches-3597233 ] Win32: use binary open mode by default everywhere

[Hans-Christoph Steiner]

On Dec 21, 2012, at 5:34 PM, Claude Heiland-Allen wrote:

> On 21/12/12 22:27, SourceForge.net wrote:
>> Patches item #3597233, was opened at 2012-12-18 08:43
>> Message generated for change (Comment added) made by eighthave
>> You can respond by visiting:
>> https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3597233&group_id=55736
>> 
>> Summary: Win32: use binary open mode by default everywhere
>> 
>> Initial Comment:
>> This patch enables binary open mode on Win32 everywhere, thereby ignoring the special Win32 "text" translation mode.  This makes the Win32 API more like the POSIX API, which is used by every other platform Pd supports.
>> 
>> But it seems to break somethings, like the loading of some soundfiles.  Attached is an example patch for the failure.
> 
> Guessing here: a file saved wrongly in text mode (by old Pd, perhaps) might be corrupted in a way that text mode old Pd can read fine, but makes binary mode software (like new Pd, perhaps) fails.
> 
> (sorry for not checking the example patch or using sf.net tracker)

Unfortuantely, it seems more insidious than that since it only affects MinGW builds...  I was testing using the classic voice.wav, which has been in continuous service to Pd users bringing soft and relaxing sounds to their headphones.

.hc