[PD-dev] remove tk scaling

[IOhannes m zmoelnig]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-06-18 19:39, Hans-Christoph Steiner wrote:
> 
> In general, removing bits of code willy-nilly is a bad idea.

sure.

> In this case, So follow what the comment there says: "This
> guarantees that patches will be pixel-exact on every platform".

this obviously hints at some underlying problem.
still it would be great to have more references in the comments, e.g.
"without this, objectbox sizes will be off by one on *BSD platforms,
cf. http://bugs.puredata.info/42 and http://wiki.tcl.tk/666)"

the vc-log doesn't reveal a lot here (the line in question has been
added in commitish b23a763e "import new tcl code from devel" :-()
the situation has become a bit better, now that "3rd party
contributions" (anybody but miller) use git for smaller commits.


in any case, i strongly suggest that each non-obvious addition to the
code should be backed up by evidence.
"this is time-proven code that guarantees the same behaviour on all
platforms, and your addition has not been tested" is a bit of a
show-stopper wehn it comes to new development.

nevertheless, here is some discussion that backs up *not* removing the
line:
http://lists.puredata.info/pipermail/pd-list/2007-11/056834.html


ghsmdf
IOhannes
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Icedove - http://www.enigmail.net/

iEYEARECAAYFAlHBYMoACgkQkX2Xpv6ydvRb7wCg2GyOFll5FGdvg9U59l3hTvvh
ZzoAn2zxVoaLrmzfsUflZAPhCqbwbxg8
=sdfC
-----END PGP SIGNATURE-----