[PD-dev] clang warning fixes

[Miller Puckette]

OK... I believe they're all up now.

thanks
M

On Sat, Apr 02, 2016 at 11:18:22PM -0600, Dan Wilcox wrote:
> I reopened the PR and added the stddef.h->stdlib.h update.
> 
> --------
> Dan Wilcox
> @danomatika <https://twitter.com/danomatika>
> danomatika.com <http://danomatika.com/>
> robotcowboy.com <http://robotcowboy.com/>
> > On Apr 2, 2016, at 10:52 PM, Miller Puckette <msp at ucsd.edu> wrote:
> > 
> > OK... no need to do anything, I'll just check them over and see.  I'm coming
> > round to thinking that they're probably worth including.
> > 
> > M
> > 
> > On Sat, Apr 02, 2016 at 10:45:43PM -0600, Dan Wilcox wrote:
> >> Yes, you can. I only closed it since I thought it involved too many small changes, but I can reopen. The warning-fixes3 patch is basically the same fixes just without adding the parentheses around assignments.
> >> 
> >> 
> >> --------
> >> Dan Wilcox
> >> @danomatika <https://twitter.com/danomatika>
> >> danomatika.com <http://danomatika.com/>
> >> robotcowboy.com <http://robotcowboy.com/>
> >>> On Apr 2, 2016, at 10:43 PM, Miller Puckette <msp at ucsd.edu> wrote:
> >>> 
> >>> I notice that the "warning-fixes" pull request is marked 'closed' - is it
> >>> still what I should be looking at?
> >>> 
> >>> thanks
> >>> M
> >>> 
> >>> On Fri, Apr 01, 2016 at 02:47:19AM -0600, Dan Wilcox wrote:
> >>>> Also, let me know if I should submit patches like this to the patch tracker. I figured I’d ask for feedback and take a couple stabs at it first here & on GitHub before adding any more noise to SF.
> >>>> 
> >>>> --------
> >>>> Dan Wilcox
> >>>> @danomatika <https://twitter.com/danomatika>
> >>>> danomatika.com <http://danomatika.com/>
> >>>> robotcowboy.com <http://robotcowboy.com/>
> >>>>> On Apr 1, 2016, at 2:36 AM, Dan Wilcox <danomatika at gmail.com> wrote:
> >>>>> 
> >>>>> Since no one is biting, I managed to fix most of the warnings by defining HAVE_ALLOCA_H and -Wno-parentheses in the Makefile.
> >>>>> 
> >>>>> Here’s a patch with the residuals: 
> >>>>> 
> >>>>> * add default: break; for unhandled case statements
> >>>>> * change stddef.h include to stdlib.h for alloca() on BSD as per Tobias request
> >>>>> 
> >>>>> <warning_fixes3.patch>
> >>>>> 
> >>>>>> Howdy all,
> >>>>>> 
> >>>>>> I put the proposed changes in the previous patches into a couple WIP branches on GH.
> >>>>>> 
> >>>>>> https://github.com/pure-data/pure-data/pull/11 <https://github.com/pure-data/pure-data/pull/11> <https://github.com/pure-data/pure-data/pull/11 <https://github.com/pure-data/pure-data/pull/11>>
> >>>>>> 
> >>>>>> https://github.com/pure-data/pure-data/pull/12 <https://github.com/pure-data/pure-data/pull/12> <https://github.com/pure-data/pure-data/pull/12 <https://github.com/pure-data/pure-data/pull/12>>
> >>>>> 
> >>>>> --------
> >>>>> Dan Wilcox
> >>>>> @danomatika <https://twitter.com/danomatika>
> >>>>> danomatika.com <http://danomatika.com/>
> >>>>> robotcowboy.com <http://robotcowboy.com/>
> >>>> 
> >> 
> 

> _______________________________________________
> Pd-dev mailing list
> Pd-dev at lists.iem.at
> http://lists.puredata.info/listinfo/pd-dev