[PD-dev] comport - compilation with mingw

[Roman Haefeli]

Hey all

I'm trying to cross-compile comport for Windows on Linux and stumbled
across this error:

i686-w64-mingw32-gcc -DPD -I "/home/roman/.wine/drive_c/Pd//src/" -DMSW -DNT     -o comport.o -c comport.c
comport.c: In function ‘set_break’:
comport.c:422:29: error: ‘nr’ undeclared (first use in this function)
     if (status != 0) return nr;

Interestingly, only the compiler that targets Windows complains about
it. comport compiles fine for all Linux platforms I tried. 

Without really understanding what the purpose of the parent function
'set_break' is, I went ahead and "fixed" line 422 to:

     if (status != 0) return on;

I can now compile comport for Windows (and still for Linux) and the resulting binary loads fine, but I'm not able to judge whether this is a sensible fix. I simply tried to address what error message gave me without really knowing what I'm doing.

Can someone confirm that it was broken before this is the right way to address it?

I got comport from:
http://git.puredata.info/cgit/svn2git/libraries/comport.git/

Thanks,
Roman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part
URL: <http://lists.puredata.info/pipermail/pd-dev/attachments/20170226/a166bde2/attachment.sig>