[PD-dev] TCL_*_VERSION variables

[Dan Wilcox]

Gotcha. We more or less removed them in IOhannes updated PR: https://github.com/pure-data/pure-data/pull/225 <https://github.com/pure-data/pure-data/pull/225>

> On Sep 21, 2017, at 5:55 PM, Miller Puckette <msp at ucsd.edu> wrote:
> 
> In that case I'd recommend making it a function of some sort, not global
> variables, which have bitten us in the past.  In particular, global vars are
> complicated to use during start-up as you have to be careful about what order
> everything runs in.
> 
> cheers
> Miller
> 
> On Thu, Sep 21, 2017 at 10:18:57AM +0200, Dan Wilcox wrote:
>> Well, I'm hoping to use them or at least the patch level. That made more sense to me then parsing the patchlevel string each time.
>> 
>> enohp ym morf tnes
>> -----------
>> Dan Wilcox
>> danomatika.com
>> robotcowboy.com
>> 
>> 
>>> On Sep 21, 2017, at 10:03 AM, IOhannes m zmoelnig <zmoelnig at iem.at> wrote:
>>> 
>>>> On 2017-09-20 23:37, Dan Wilcox wrote:
>>>> Where are the TCL_MAJOR_VERSION, TCL_MINOR_VERSION, & TCL_BUGFIX_VERSION set? There are listed as globals in pd-gui.tcl and don't seem to be set on mac when running Pd from the command line. I'm trying to check the BUGFIX version in order to detect if the buggy 8.5.9 is being used on macOS.
>>> 
>>> 
>>> here they are set to (0,0,0), which is the default in pd-gui.tcl:117ff
>>> (for all platforms).
>>> since it's nowhere used (neither set nor consumed), despite the comment
>>> on top of it, it should probably be removed completely.
>>> 
>>> gfamsdr
>>> IOhannes
>>> 
>> 
>> _______________________________________________
>> Pd-dev mailing list
>> Pd-dev at lists.iem.at
>> https://lists.puredata.info/listinfo/pd-dev

--------
Dan Wilcox
@danomatika <http://twitter.com/danomatika>
danomatika.com <http://danomatika.com/>
robotcowboy.com <http://robotcowboy.com/>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.puredata.info/pipermail/pd-dev/attachments/20170922/1108bcfb/attachment-0001.html>