[PD-dev] mac save as crash, was: savestate

[Miller Puckette]

Think I found it - a careless edit on my part... in tk8.5.19/macosx/tkMacOSXKeyEvent.c
the lines:

    case NSKeyUp:
      if (finishedCompose)
       if (!releaseCode)
	return theEvent;

should be just:

    case NSKeyUp:
       if (!releaseCode)
        return theEvent;

I'll update the source tarball and make a compiled one just so we're all on the
same page.  Deleting that one line has stopped the "save as" crashes for me, and
might also have fixed the other current crasher.

cheers
M

On Tue, Sep 11, 2018 at 06:14:45PM -0700, Miller Puckette wrote:
> Yes, I'm running on the theory that it's my keyup patch that's doing this.
> 
> M
> 
> On Wed, Sep 12, 2018 at 01:26:12AM +0200, Dan Wilcox wrote:
> > I'm seeing the same on macOS 10.13.6. This is a crash in the GUI and seems to be something to do with the Tk version as running PD with the built-in version of Tk on my system works fine.
> > 
> > > On Sep 12, 2018, at 12:20 AM, pd-dev-request at lists.iem.at wrote:
> > > 
> > > From: jakob skouborg <syntaxerror60 at hotmail.com <mailto:syntaxerror60 at hotmail.com>>
> > > 
> > > but I think I might have experienced a bug here on OSX 10.10.5(Yosemite):
> > > 
> > > - When I do a ???save as??? and I type in the name in the save dialog and then push ??? Save as??? button, PD crashed. I have not been able to save a patch yet.
> > > 
> > > Can anyone replicate?
> > > 
> > > Thanks and have a great evening ;)
> > > 
> > > Jakob(Jaffasplaffa)
> > 
> > --------
> > Dan Wilcox
> > @danomatika <http://twitter.com/danomatika>
> > danomatika.com <http://danomatika.com/>
> > robotcowboy.com <http://robotcowboy.com/>
> > 
> > 
> > 
> 
> > _______________________________________________
> > Pd-dev mailing list
> > Pd-dev at lists.iem.at
> > https://lists.puredata.info/listinfo/pd-dev
> 
> 
> 
> 
> _______________________________________________
> Pd-dev mailing list
> Pd-dev at lists.iem.at
> https://lists.puredata.info/listinfo/pd-dev