[PD-dev] Re : Re: Sigmund~ error?

[Nicolas Danet]

Hi, 

I'm refactoring the code as i need to make it thread-safe. That's why. I do it step by step with extra care as TBH i don't understand all the mathematics involved (specially since i didn't find any paper about what's happened under the hood). I didn't proposed a pull request because as you said it needs much more tests. But after cleaning it, i'm almost sure that the three points i have reported (i've just posted another possible issue in the other thread) can lead to buffer overflow. I guess in fact it never happens since there is never enought power in highest frequencies.

----- Mail d'origine -----
De: Miller Puckette <msp at ucsd.edu>
À: Nicolas Danet <nicolas.danet at free.fr>
Cc: pd-dev at lists.iem.at
Envoyé: Wed, 28 Nov 2018 16:47:23 +0100 (CET)
Objet: Re: [PD-dev] Sigmund~ error?

Just looking now...  I think you're right on both counts, but the code is
so dense I'll need to look at it again later and make sure I'm not getting
thrown off (particularly by the "cbin" question under separate cover).

In fact, I'm impressed you can understand that code... I don't anymore
myself.

cheers
Miller

On Mon, Nov 26, 2018 at 04:38:56PM +0100, Nicolas Danet wrote:
> Hi list,
> 
> In sigmund~.c line 228 / < https://github.com/pure-data/pure-data/blob/master/extra/sigmund%7E/sigmund%7E.c#L228 >
> 
> Is that,
> 
> int bin2 = (maxbin < bestindex + 50 ? bestindex + 50 : maxbin);
> 
> should not be instead:
> 
> int bin2 = (maxbin > bestindex + 50 ? bestindex + 50 : maxbin);
> 
> I'm probably wrong, but in case, somebody could check?
> 
> 
> 
> _______________________________________________
> Pd-dev mailing list
> Pd-dev at lists.iem.at
> https://lists.puredata.info/listinfo/pd-dev