[PD-dev] unifying loglevels

[IOhannes m zmoelnig]

On 8/24/21 9:44 PM, Christof Ressi wrote:
>> for unknown reasons, the values accepted by verbose() and logpost() 
>> have an offset. 
> Why? Oh why?

i've been involved in that code, and i don't have an anwer :-(

> 
> If we let PD_CRITICAL start at 5 (or even higher), then both verbose() 
> and logpost() can differentiate between the old and the new log levels 
> and add the respective offsets.
> 
> if (loglevel >= PD_CRITICAL) {
>      // new log level
> } else {
>      // old log level
> }

ah well, but there's externals that happen to use even higher loglevels.
one could of course shift the PD_CRITICAL to e.g. 1000 or so to be on 
the safe side.
but then: why not fix the offending libraries instead?

gf,masdr
IOhannes

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://lists.puredata.info/pipermail/pd-dev/attachments/20210825/09702328/attachment-0001.sig>