[PD] iemgui_save (was Re: [PD-announce] Pd-extended 0.43.4 release candidate 1: last chance to report your bugs)

IOhannes m zmoelnig zmoelnig at iem.at
Thu Jan 17 09:21:55 CET 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-01-17 06:38, Hans-Christoph Steiner wrote:
> 
> Turns out the problem was the & character in the label.  I fixed it
> so please test in tomorrow's build (2013-01-17)
> 
> This patch is what fixes it: 
> http://sourceforge.net/tracker/index.php?func=detail&aid=2947822&group_id=55736&atid=478072
>
>  About the labels not showing up when the patch loads, that's
> because you are saving the patch with a label that has spaces in
> it, which the iemgui objects do not handle.  In your patch, you
> could fix it by using _ instead of spaces, like by using [l2s _].
> 
> This could be fixed if iemgui_save() escaped spaces with \ and
> removed characters like ;,{}\ from the symbol.  I'll try to
> implement that, but I won't get to it tonight.
> 

i think these kind of things _must_ be implemented on the Pd-side.
saving a symbol does something like

> binbuf_addv(b, "s", x->x_sym); /* this code is in the object-class
> */ binbuf_write(b, ...);          /* this is global saving code */

so fixing the problem can really only be done in binbuf_write().

now if you introduce a change here, this will effect each and every
object that get's saved.
i would definitely not recommend to do such a change that late in the
release cycle.


fgasdf
IOhannes
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlD3tJUACgkQkX2Xpv6ydvRizACgzb29oGwPtFgSgl9uChSz2JNe
3OcAoIMkYeEaBoL8jdN0W8omcZZlGRNR
=gHDd
-----END PGP SIGNATURE-----



More information about the Pd-list mailing list