[PD] bbogart's popup

[Peter P.]

* Claude Heiland-Allen <claude at mathr.co.uk> [2015-04-13 18:47]:
> On 13/04/15 22:56, Peter P. wrote:
> >Hi list,
> >
> >trying to compile Ben Bogart's popup object from svn, executing
> >	make pd_linux
> >in the popup source directory. Getting the following error though:
> >
> >cc -DPD -O2 -funroll-loops -fomit-frame-pointer -Wall -W -Wshadow
> >-Wstrict-prototypes -Werror -Wno-unused -Wno-parentheses -Wno-switch
> >-I../../src -I../../../pd/src -o popup.o -c popup.c
> >popup.c: In function ‘popup_activate’:
> >popup.c:306:36: error: unused parameter ‘z’ [-Werror=unused-parameter]
> >  static void popup_activate(t_gobj *z, t_glist *glist, int state)
> >
> >[...]
> >
> >cc1: all warnings being treated as errors
> 
> delete -Werror from the makefile.
> 
> probably compiler added/changed warnings since popup was written - this is
> why -Werror should not be used unless specified manually by the developer
> during testing.
> 
> there are many (around 70) instances of -Werror in various build systems in
> the pd svn.  they should all be removed.
> 
> btw, after doing this it still failed to link for me - missing -fPIC
> required on my architecture - so add that to the makefile too while you're
> there.

Thank you so much Claude, this is amazing, fast, wonderful help! Of
course the object compiles really nicely after your changes have been
done to the makefile.

best, P