[PD] [ggee/notch] / [ggee/bandpass] seem to work at default/fixed samplerate of 44100

[Fred Jan Kraan]

Hi IOhannes,

> On 2015-05-03 15:58, Fred Jan Kraan wrote:

>>
>> A patch to fix them all is easy to make and add to sourceforge.
>
> thanks for your efforts.
>
> have you tested this in a subpatch that uses re-sampling (and/or overlap)?
>
> afaik, the *proper* way to get the samplerate for oscillators is to use
> the `s_sr` member of the signal-struct: "sp[0]->s_sr"
> at least this is how it is done in all Pd-internal oscillators, and i
> guess it would make sense to have this behaviour be consistent across
> all oscillators (whether internal or external).

Thanks for the response. I hoped the patch would be an improvement to 
the current situation, but apparently there is more room for 
improvement. It will take some more time to understand, include and test 
these.
>
> fgams
> IOhannes
>
Greetings,

Fred Jan